pgindent run?

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian writes:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Are there any severely mis-indented files?

Not sure. I think there are some. It doesn't do anything unless there
is mis-indenting, so it is pretty safe and has always been done in the
past. It obviously only affects new changes since the last run.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On Wed, 21 Mar 2001, Bruce Momjian wrote:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

Since I'm going to end up re-rolling RC1, do a run tonight on her, so that
any problems that arise from pgindent this time can be caught with those
testing RC1 ...

On Wed, 21 Mar 2001, Bruce Momjian wrote:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

Since I'm going to end up re-rolling RC1, do a run tonight on her, so that
any problems that arise from pgindent this time can be caught with those
testing RC1 ...

Good idea. It is well tested, but you never know.

Peter, this is the optimial time to do it because no one has any
outstanding patches at this point. Seems this is the only good time.

Unless someone says otherwise, I will do the run tonight.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian writes:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Are there any severely mis-indented files?

--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/

Bruce Momjian writes:

Peter, this is the optimial time to do it because no one has any
outstanding patches at this point. Seems this is the only good time.

Actually, I have quite a few outstanding patches. I got screwed by this
last time around as well. But I understand that this might be the best
time.

That you are holding? Yes, I have a few to at my new Unapplied
Patches web page:

http://candle.pha.pa.us/cgi-bin/pgpatches

The good news is that these will apply fine to 7.2 unless they touch an
area that needed indenting. The problem of not doing it is that the
code starts to look different after a while and takes on a chaotic feel.

This is probably the time when there are the fewest oustanding patches,
I guess.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian writes:

Peter, this is the optimial time to do it because no one has any
outstanding patches at this point. Seems this is the only good time.

Actually, I have quite a few outstanding patches. I got screwed by this
last time around as well. But I understand that this might be the best
time.

--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/

OK, I am going to have dinner and then get started on the pgindent run.

I have also noticed we have some comments like:

/* ----
* one word
* ----
*/

that look funny in a few places. I propose:

/* one word */

to be consistent.

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

-- 
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 853-3000
+  If your life is a hard drive,     |  830 Blythe Avenue
+  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On Wed, 21 Mar 2001, Bruce Momjian wrote:

OK, I am going to have dinner and then get started on the pgindent run.

I have also noticed we have some comments like:

/* ----
* one word
* ----
*/

that look funny in a few places. I propose:

/* one word */

to be consistent.

to be consistent with what ... ? isn't:

/* ----------
* comment
* ----------
*/

the standard?

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

--
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 853-3000
+  If your life is a hard drive,     |  830 Blythe Avenue
+  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

--
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 853-3000
+  If your life is a hard drive,     |  830 Blythe Avenue
+  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

On Wed, 21 Mar 2001, Bruce Momjian wrote:

OK, I am going to have dinner and then get started on the pgindent run.

I have also noticed we have some comments like:

/* ----
* one word
* ----
*/

that look funny in a few places. I propose:

/* one word */

to be consistent.

to be consistent with what ... ? isn't:

/* ----------
* comment
* ----------
*/

the standard?

Sorry. It has been a while since I studied this. The issue is the
dashes, not the block comments. /* --- is needed for multi-line comment
where you want to preserve the layout, but in other cases, it prevents
comment layout and looks kind of heavy. I eyeball each change to make
sure it is clean so:

/* ---
* test
* ---
*/

becomes the cleaner:

/*
* test
*/

This makes the comment easier to read.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Bruce Momjian <pgman@candle.pha.pa.us> writes:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

If you're going to do it before the release, I think you should do it
*before* we wrap RC1. I've said before and will say again that I think
it's utter folly to run pgindent at the conclusion of the test cycle.
I've been around this project for three major release cycles and we have
seen errors introduced by pgindent in two of them. I don't trust
pgindent to be bug-free and I don't believe you should either.

regards, tom lane

Bruce Momjian <pgman@candle.pha.pa.us> writes:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

If you're going to do it before the release, I think you should do it
*before* we wrap RC1. I've said before and will say again that I think
it's utter folly to run pgindent at the conclusion of the test cycle.
I've been around this project for three major release cycles and we have
seen errors introduced by pgindent in two of them. I don't trust
pgindent to be bug-free and I don't believe you should either.

OK, running now. Should I run it at another time or never?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Are there any severely mis-indented files?

There are some new contrib modules that are nowhere close to our
indent conventions; also a good deal of foreign-key-related stuff
in the parser that needs to be cleaned up. So we should run it.

I've always felt that it'd be smarter to run pgindent at the start
of a development cycle, not the end, but I've been unable to convince
Bruce of that ...

regards, tom lane

Are there any severely mis-indented files?

There are some new contrib modules that are nowhere close to our
indent conventions; also a good deal of foreign-key-related stuff
in the parser that needs to be cleaned up. So we should run it.

I've always felt that it'd be smarter to run pgindent at the start
of a development cycle, not the end, but I've been unable to convince
Bruce of that ...

Hey, I am open to whatever people want to do. Just remember that we
accumulate lots of patches/development during the slow time before
development, and those patches become harder to apply. Peter E has some
already.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

* Bruce Momjian <pgman@candle.pha.pa.us> [010321 22:11]:

Are there any severely mis-indented files?

There are some new contrib modules that are nowhere close to our
indent conventions; also a good deal of foreign-key-related stuff
in the parser that needs to be cleaned up. So we should run it.

I've always felt that it'd be smarter to run pgindent at the start
of a development cycle, not the end, but I've been unable to convince
Bruce of that ...

Hey, I am open to whatever people want to do. Just remember that we
accumulate lots of patches/development during the slow time before
development, and those patches become harder to apply. Peter E has some
already.

How about:
1) just AFTER release
2) just BEFORE Beta

LER

-- 
Bruce Momjian                        |  http://candle.pha.pa.us
pgman@candle.pha.pa.us               |  (610) 853-3000
+  If your life is a hard drive,     |  830 Blythe Avenue
+  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

On Wed, 21 Mar 2001, Bruce Momjian wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

With RC1 nearing, when should I run pgindent? This is usually the time
I do it.

Does the silence mean I should pick a date to run this?

If you're going to do it before the release, I think you should do it
*before* we wrap RC1. I've said before and will say again that I think
it's utter folly to run pgindent at the conclusion of the test cycle.
I've been around this project for three major release cycles and we have
seen errors introduced by pgindent in two of them. I don't trust
pgindent to be bug-free and I don't believe you should either.

OK, running now. Should I run it at another time or never?

I'll put my vote on Tom's side of things ... run if after the release,
right at the start of the next development cycle, so that any bugs that
crop up aren't just as we are trying to release ...

Hell, maybe once then and once *just* as we are going into first beta of a
release ... Tom?

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Hey, I am open to whatever people want to do. Just remember that we
accumulate lots of patches/development during the slow time before
development, and those patches become harder to apply. Peter E has some
already.

Why not start a devel cycle by (a) branching the tree, (b) applying
all held-over patches, and then (c) running pgindent?

I'd probably wait a week or so between (a) and (c) to let people push
in whatever they have pending. But in general it seems a lot safer
to pgindent at the front end of the cycle not the back end.

regards, tom lane

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Hey, I am open to whatever people want to do. Just remember that we
accumulate lots of patches/development during the slow time before
development, and those patches become harder to apply. Peter E has some
already.

Why not start a devel cycle by (a) branching the tree, (b) applying
all held-over patches, and then (c) running pgindent?

If people can get their patches in all at one time, that would work.
The only problem there is that people who supply patches against 7.1
will not match the 7.2 tree, and we get those patches from people for
months.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On Wed, 21 Mar 2001, Bruce Momjian wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Hey, I am open to whatever people want to do. Just remember that we
accumulate lots of patches/development during the slow time before
development, and those patches become harder to apply. Peter E has some
already.

Why not start a devel cycle by (a) branching the tree, (b) applying
all held-over patches, and then (c) running pgindent?

If people can get their patches in all at one time, that would work.
The only problem there is that people who supply patches against 7.1
will not match the 7.2 tree, and we get those patches from people for
months.

and those patches should only be applied to the v7.1 branch ... we are
suggesting (or, at least, I am) is that you pgindent *HEAD* after we've
branched off v7.1 ...

... that way, we go into the new dev cycle "clean", but we doon't mess up
the *STABLE* tree ...