RC3 ... anyone have anything left outstanding?

The Hermit Hacker <scrappy@hub.org> writes:

Thomas? Did I miss your patch for the 'WITH TIMEZONE' regression test?

Still not there in CVS ...

Does anyone else have anything left outstanding that should hold me off
from doing an RC3 tomorrow?

Other than a better answer for the horology test, I think we are good
to go. The main thing that was still bothering me was Konstantin
Solodovnikov's report of database corruption. I just committed a fix
for the primary cause of that problem: turns out he was triggering a
random transfer of control inside plpgsql. (Calling through a
previously freed function pointer is uncool...) I'm guessing that the
ensuing corruption of the database can be blamed on whatever bit of code
managed to misexecute before the backend crashed completely. This is
plausible because he reports that he only saw corruption in perhaps one
out of every several hundred repetitions of the crash --- it makes sense
that you'd need to mistransfer just so to result in writing junk XLOG
entries or whatever was the direct cause of the data corruption.

Vadim is still poking at the test case Konstantin sent, but I'll bet
he won't be able to reproduce any corruption. The effects of jumping
through an overwritten function pointer would be exceedingly
system-specific.

regards, tom lane

Okay, unless I hear different from anyone out there, I'm goin to roll RC3
when I get to work tomorrow, and announce it before I leave (to give it
some time to propogate to the mirrors) ...

On Thu, 5 Apr 2001, Tom Lane wrote:

The Hermit Hacker <scrappy@hub.org> writes:

Thomas? Did I miss your patch for the 'WITH TIMEZONE' regression test?

Still not there in CVS ...

Does anyone else have anything left outstanding that should hold me off
from doing an RC3 tomorrow?

Other than a better answer for the horology test, I think we are good
to go. The main thing that was still bothering me was Konstantin
Solodovnikov's report of database corruption. I just committed a fix
for the primary cause of that problem: turns out he was triggering a
random transfer of control inside plpgsql. (Calling through a
previously freed function pointer is uncool...) I'm guessing that the
ensuing corruption of the database can be blamed on whatever bit of code
managed to misexecute before the backend crashed completely. This is
plausible because he reports that he only saw corruption in perhaps one
out of every several hundred repetitions of the crash --- it makes sense
that you'd need to mistransfer just so to result in writing junk XLOG
entries or whatever was the direct cause of the data corruption.

Vadim is still poking at the test case Konstantin sent, but I'll bet
he won't be able to reproduce any corruption. The effects of jumping
through an overwritten function pointer would be exceedingly
system-specific.

regards, tom lane

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

Okay, unless I hear different from anyone out there, I'm goin to roll RC3
when I get to work tomorrow, and announce it before I leave (to give it
some time to propogate to the mirrors) ...

The Hermit Hacker <scrappy@hub.org> writes:

Thomas? Did I miss your patch for the 'WITH TIMEZONE' regression test?

Still not there in CVS ...

I've committed a fix to the horology regression test which keeps *some*
kind of test for the "time with time zone" type with an implicit time
zone. Not ideal, but we can work on it later.

btw, I've applied the patch for the expected/ files to all variants of
horology.out, so all platforms should pass that test now.

I've also committed the up to date platform list, which has 30 distinct
platforms supported!! Thanks to Henry Hotz for getting us to that magic
number with NetBSD/ppc.

- Thomas

Thomas Lockhart <lockhart@alumni.caltech.edu> writes:

btw, I've applied the patch for the expected/ files to all variants of
horology.out, so all platforms should pass that test now.

FWIW, I confirm that horology-no-DST-before-1970 is good; it passes on
HPUX. Can anyone confirm horology-solaris-1947?

regards, tom lane

FWIW, I confirm that horology-no-DST-before-1970 is good; it passes on
HPUX. Can anyone confirm horology-solaris-1947?

How to test it? All default tests are Ok on my Solaris.

Vadim

"Mikheev, Vadim" <vmikheev@SECTORBASE.COM> writes:

FWIW, I confirm that horology-no-DST-before-1970 is good; it passes on
HPUX. Can anyone confirm horology-solaris-1947?

How to test it? All default tests are Ok on my Solaris.

If the horology test shows as passing, then we're set.

regards, tom lane