Newest Patch...try this one...

Started by The Hermit Hackeralmost 28 years ago9 messages
#1The Hermit Hacker
scrappy@hub.org

ftp.postgresql.org/pub/patches/.test/v6.3p1beta3.gz

Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

#2Noname
t-ishii@sra.co.jp
In reply to: The Hermit Hacker (#1)
Re: [HACKERS] Newest Patch...try this one...

At 7:57 PM 98.3.20 -0400, The Hermit Hacker wrote:

ftp.postgresql.org/pub/patches/.test/v6.3p1beta3.gz

I have tested the patch on my FreeBSD 2.2.5 box.
Here are quick reports.

o the patch command needs -p1 and -l option. It would be nice
if this is mentioned in README or whatever.
o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.
Tatsuo Ishii
t-ishii@sra.co.jp

#3The Hermit Hacker
scrappy@hub.org
In reply to: Noname (#2)
Re: [HACKERS] Newest Patch...try this one...

On Sat, 21 Mar 1998, Tatsuo Ishii wrote:

o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.

This patch represents what has changed between the tar file that
is v6.3 and the source tree that is current...if there is an unnecessary
patch, then it should most likely be removed from current tree altogether,
no?

Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

#4Noname
t-ishii@sra.co.jp
In reply to: The Hermit Hacker (#3)
Re: [HACKERS] Newest Patch...try this one...

At 2:42 PM 98.3.21 -0400, The Hermit Hacker wrote:

On Sat, 21 Mar 1998, Tatsuo Ishii wrote:

o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.

This patch represents what has changed between the tar file that
is v6.3 and the source tree that is current...if there is an unnecessary
patch, then it should most likely be removed from current tree altogether,
no?

I don't know why this happens, but...

It seems that the patch is trying to create a new file of geqo_path.c
which is identical to existing geqo_path.c in the 6.3 tar file.
As a result, dupliation of it is performed by the patch.
To confirm above, take a look at the RCS id of geqo_path.c
in the tar file and the patch.
You will find they are same (1.8 created on 1998/2/26).
--
Tatsuo Ishii
t-ishii@sra.co.jp

#5Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Noname (#2)
Re: [HACKERS] Newest Patch...try this one...

At 7:57 PM 98.3.20 -0400, The Hermit Hacker wrote:

ftp.postgresql.org/pub/patches/.test/v6.3p1beta3.gz

I have tested the patch on my FreeBSD 2.2.5 box.
Here are quick reports.

o the patch command needs -p1 and -l option. It would be nice
if this is mentioned in README or whatever.
o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.
Tatsuo Ishii
t-ishii@sra.co.jp

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)
#6Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Noname (#2)
Re: [HACKERS] Newest Patch...try this one...

o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.
Tatsuo Ishii
t-ishii@sra.co.jp

I am confused about this item. cvs shows no changes in this file since
the 6.3 release.

---------------------------------------------------------------------------

RCS file: /usr/local/cvsroot/pgsql/src/backend/optimizer/geqo/geqo_paths.c,v
Working file: geqo_paths.c
head: 1.8
branch:
locks: strict
access list:
symbolic names:
release-6-3: 1.8
keyword substitution: kv
total revisions: 8; selected revisions: 8
description:
----------------------------
revision 1.8
date: 1998/02/26 04:32:23; author: momjian; state: Exp; lines: +2 -2
pgindent run before 6.3 release, with Thomas' requested changes.
----------------------------
revision 1.7
date: 1997/09/08 21:44:32; author: momjian; state: Exp; lines: +7 -7
Used modified version of indent that understands over 100 typedefs.

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)
#7Noname
t-ishii@sra.co.jp
In reply to: Bruce Momjian (#6)
Re: [HACKERS] Newest Patch...try this one...

I just put the final patch in place (unannounced) for anyone to try out...

ftp://ftp.postgresql.org/pub/postgresql-6.3-6.3.1.gz

Unless there are any outstandign problems with either that patch or the
full distribution, I will put out an announcement of those two Monday
morning...

It seems still the problem below exists in postgresql-6.3-6.3.1.gz.
(I haven't checked postgresql-6.3.1.tar.gz yet)

Show quoted text

o an unnecceary patch (I guess) for
backend/optimizer/geqo/geqo_paths.c included. This cause some
compile errors.

This patch represents what has changed between the tar file that
is v6.3 and the source tree that is current...if there is an unnecessary
patch, then it should most likely be removed from current tree altogether,
no?

I don't know why this happens, but...

It seems that the patch is trying to create a new file of geqo_path.c
which is identical to existing geqo_path.c in the 6.3 tar file.
As a result, dupliation of it is performed by the patch.
To confirm above, take a look at the RCS id of geqo_path.c
in the tar file and the patch.
You will find they are same (1.8 created on 1998/2/26).

#8The Hermit Hacker
scrappy@hub.org
In reply to: Noname (#7)
Re: [HACKERS] Newest Patch...try this one...

On Mon, 23 Mar 1998 t-ishii@sra.co.jp wrote:

I just put the final patch in place (unannounced) for anyone to try out...

ftp://ftp.postgresql.org/pub/postgresql-6.3-6.3.1.gz

Unless there are any outstandign problems with either that patch or the
full distribution, I will put out an announcement of those two Monday
morning...

It seems still the problem below exists in postgresql-6.3-6.3.1.gz.
(I haven't checked postgresql-6.3.1.tar.gz yet)

I don't know how, but for some reason, the geqo_paths.c that was
untar'd from the 6.3 tar file came out zero length...rebuilding the patch
now...

Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org

#9The Hermit Hacker
scrappy@hub.org
In reply to: Noname (#4)
Re: [HACKERS] Newest Patch...try this one...

It seems that the patch is trying to create a new file of geqo_path.c
which is identical to existing geqo_path.c in the 6.3 tar file.
As a result, dupliation of it is performed by the patch.
To confirm above, take a look at the RCS id of geqo_path.c
in the tar file and the patch.
You will find they are same (1.8 created on 1998/2/26).

Fixed...I will be regenerating the patch as well as the tar file
tomorrow morning, prior to announcing...

Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org