Aug 2019

3 commits
Fix error handling of vacuumdb when running out of fds
26 Aug 2019Michael PaquierREL_12_STABLE12beta4REL_11_STABLE11.6REL_10_STABLE10.11REL9_6_STABLE9.6.16REL9_5_STABLE9.5.20
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #323 of 3 reviewers saw the final version

This is the vacuumdb-only branch adaptation of #32: src/bin/scripts/vacuumdb.c removes the argument-limit check and validates PQsocket(conn) in vacuum_one_database(), without the shared-code or reindexdb changes. It incorporates the final diagnostic wording, changes the suggested count from i - 1 to i, and tightens the comment, matching the backpatch announcement in #37.

  • Andres Freundsaw the final versiontrailerAndres requested earlier socket validation in #21, reviewed the revised scope and comments in #23, and challenged the final patch's i - 1 hint in #33.
  • Álvaro Herrerasaw the final versiontrailerÁlvaro requested translatable logging and a useful job-count hint in #24 and refined that hint in #27 and #29, followed only by light diagnostic and comment changes.
  • Tom Lanesaw the final versiontrailerTom justified the hint using POSIX descriptor allocation in #30 and supplied the committed error wording in #35.
Fix error handling of vacuumdb and reindexdb when running out of fds
26 Aug 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #323 of 3 reviewers saw the final version

The commit preserves all four files and the setup-time socket validation of #32. The remaining edits shorten the comment, remove the select() reference from the diagnostic as proposed in #35, and correct the suggested job count from i - 1 to i following #33.

  • Andres Freundsaw the final versiontrailerAndres requested earlier socket validation in #21, reviewed the revised scope and comments in #23, and challenged the final patch's i - 1 hint in #33.
  • Álvaro Herrerasaw the final versiontrailerÁlvaro requested translatable logging and a useful job-count hint in #24 and refined that hint in #27 and #29, followed only by light diagnostic and comment changes.
  • Tom Lanesaw the final versiontrailerTom justified the hint using POSIX descriptor allocation in #30 and supplied the committed error wording in #35.
Fix compilation failure of vacuumdb and reindexdb with OpenBSD
20 Aug 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #16

Commits only the first patch of #16, adding ParallelSlotsMax() and updating vacuumdb and reindexdb, with two comment edits and declaration whitespace changes. The second patch's runtime socket check remains uncommitted, as Michael confirms in #20.

Credits across 3 commits

Author
Michael Paquier1 LLM3
Reviewer
Alvaro Herrera2
Andres Freund2
Tom Lane2
Reported by
Andres Freund2
Sean Farrell1
Committer
Michael Paquier3

N LLM means N of the credits come from LLM analysis, not from commit trailers.