Oct 2019

2 commits
Flush logical mapping files with fd opened for read/write at checkpoint
9 Oct 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+6 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #51 of 1 reviewer saw the final version

The commit exactly matches the rewriteheap.c fix in #5, changing O_RDONLY to O_RDWR and adding the explanatory comment. It omits the separate diagnostic changes to fd.c and PostgresNode.pm, which Michael explicitly supplied to illustrate how he found the bug.

  • Andres Freundsaw the final versiontrailerAndres discussed the affected case, suggested fstat() for handling directories in potential assertions, and raised no objection to the fix #8.
Use a fd opened for read/write when syncing slots during startup, take 2.
4 Oct 2019Andres Freundmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch

Andres identified the accidentally undone replication-slot fix in #2 and announced its restoration in #3, before the thread's only attached patchset. The commit changes RestoreSlotFromDisk() in src/backend/replication/slot.c to use O_RDWR and adds an explanatory comment.

Credits across 2 commits

Author
Andres Freund1
Michael Paquier1
Reviewer
Andres Freund1
Reported by
Hans Buschmann1
Committer
Andres Freund1
Michael Paquier1