Dec 2019

1 commit
Rotate instead of shifting hash join batch number.
24 Dec 2019Thomas Munromaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+6 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #531 of 5 reviewers saw the final version

The commit retains the pg_rotate_right32() helper and batch-selection change from #53, with expanded nodeHash.c comments and formatting edits. It also adopts Tom Lane's #54 suggestion to replace CHAR_BIT with BITS_PER_BYTE and remove the limits.h include; Thomas confirms the push in #55.

  • Tom Lanesaw the final versiontrailerTom benchmarked bit reversal and reported a parallel slowdown in #41, requested a clearer rotation-helper name in #52, and supplied the final constant/header adjustment in #54.
  • thanks also to Tomas Vondrasaw an earlier versiontrailerTomas challenged the rehash distribution in #29 and tested bit reversal for correctness and performance in #38 and #42, before rotation replaced that algorithm.
  • Alvaro Herrerasaw an earlier versiontrailerAlvaro assessed helper placement and the performance tradeoff of the bit-reversal patch in #37, before the later change to rotation.
  • Andres Freund for testingsaw an earlier versiontrailerAndres discussed the posted mixing approach, its performance implications, and bit reversal as an alternative in #33, before both subsequent algorithm changes.
  • discussionno review foundtrailerThis entry is a fragment of the commit's prose credit for testing and discussion, not an identifiable reviewer in the thread.

Credits across 1 commit

Author
Thomas Munro1
Reviewer
Alvaro Herrera1
Andres Freund for testing1
discussion1
thanks also to Tomas Vondra1
Tom Lane1
Reported by
James Coleman1
Committer
Thomas Munro1