Nov 2019

2 commits
Remove unnecessary clauses_attnums variable
28 Nov 2019Tomas Vondramaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Neither attachment removes clauses_attnums from statext_mcv_clauselist_selectivity(); Dean requested that cleanup in #9 and #12, and Tomas acknowledged forgetting it in #13. The commit removes its declaration and accumulation, plus redundant braces, from src/backend/statistics/extended_stats.c.

  • Dean Rasheedsaw the final versionLLM analysis, 99% sureReviewing #8 and #11, Dean identified the unnecessary clauses_attnums computation in #9 and #12, directly prompting the committed cleanup.
Fix choose_best_statistics to check clauses individually
28 Nov 2019Tomas Vondramaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #111 of 1 reviewer saw the final version

The production-code diff matches #11 exactly; the commit additionally changes src/test/regress/sql/stats_ext.sql and its expected output to test fully covered and incompletely covered OR clauses. Tomas confirms adding these regression tests before committing in #13.

  • Dean Rasheedsaw the final versiontrailerDean reviewed the interface and redundant checks in #9, then reviewed #11 for a comment typo and unused computation in #12; only regression tests were added before commitment.

Credits across 2 commits

Author
Tomas Vondra2
Reviewer
Dean Rasheed1
Reported by
Manuel Rigger1
Committer
Tomas Vondra2