Oct - Nov 2020

3 commits
In INSERT/UPDATE, use the table's real tuple descriptor as target.
8 Nov 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.1+1 moreAlso in: [BUG]: segfault during update
LLM analysis, 87% surewritten from the discussion, no matching patch

The canonical diff only extends src/test/regress/sql/triggers.sql and its expected output with a dropped-column case; neither attachment contains these changes. The commit connects this thread's descriptor fix to Bertrand Drouvot's crash report in thread #43212, which has no attached patchsets, and explains why the executor fix now needs backpatching.

In INSERT/UPDATE, use the table's real tuple descriptor as target.
26 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

The four-file diff exactly matches #7 after excluding index-line hash lengths: it introduces ExecInitJunkFilterInsertion, uses the relation descriptor for INSERT/UPDATE, and removes MaterializeTupleForTrigger.

  • Amit Langotesaw the final versionLLM analysis, 93% sureAmit examined the dropped-column mapping in ExecInitJunkFilterInsertion versus ExecInitJunkFilterConversion in #8 and followed up on downstream NULL handling in #10 before the unchanged patch landed.
Fix corner case for a BEFORE ROW UPDATE trigger returning OLD.
25 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.1+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #41 of 1 reviewer saw the final version

The commit credits Amit Langote and implements the tuple expansion proposed in #4, but extracts MaterializeTupleForTrigger, checks for missing-attribute metadata, fixes tuple ownership, and adds regression coverage. Tom describes correcting should_free handling and checking other trigger paths in #6.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Amit LangoteLLM1
Tom LaneLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.