Feb 2021

2 commits
Fix psql's ON_ERROR_ROLLBACK so that it handles COMMIT AND CHAIN.
19 Feb 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.3+1 more
LLM analysis, 99% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Arthur Nascimento described adding COMMIT to psql's savepoint handling in #1 and sent his local change in #2, whose attachment is not an indexed patchset here. The commit implements that change in src/bin/psql/common.c, and Fujii explicitly announced he would commit Arthur's psql fix in #5.

  • Fujii Masaosaw the final versiontrailerFujii accepted Arthur's psql change in #3, confirmed his intention to commit it in #5, and reviewed the final version as committer.
  • Vik Fearingsaw the final versiontrailerVik reviewed the paired fixes' savepoint semantics after #3, explaining in #6 and #8 that COMMIT destroys savepoints and AND CHAIN starts a new transaction.
Fix bug in COMMIT AND CHAIN command.
19 Feb 2021Fujii Masaomaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.3+1 more
LLM analysis, 100% surelanded as postedfrom patchset #32 of 2 reviewers saw the final version

The commit matches #3 exactly after removing blob-index metadata: the seven-line TBLOCK_SUBCOMMIT chaining fix in src/backend/access/transam/xact.c and both transactions regression-test changes are identical.

  • Arthur Nascimentosaw the final versiontrailerArthur tested #3 and confirmed in #4 that it solved his reported problem.
  • Vik Fearingsaw the final versiontrailerVik checked the intended transaction and savepoint semantics in #6 and clarified in #8 that the behavior implemented by #3 was correct.

Credits across 2 commits

Author
Arthur Nascimento1
Fujii Masao1
Reviewer
Vik Fearing2
Arthur Nascimento1
Fujii Masao1
Reported by
Arthur Nascimento2
Committer
Fujii Masao2