May 2021

2 commits
Disallow whole-row variables in GENERATED expressions.
21 May 2021Tom Lanemaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2REL_13_STABLE13.4+1 more
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #81 of 1 reviewer saw the final version

The commit takes exactly the whole-row rejection component of the two-patch series in #8: src/backend/catalog/heap.c and both generated regression files match apart from diff index metadata. The series' tableoid component landed separately in 2b0ee126bb.

  • Vitaly Ustinovsaw the final versionLLM analysis, 85% sureIn #9, he explicitly challenged the whole-row prohibition in #8 as inconsistent with BEFORE-trigger access to generated columns, prompting Tom Lane's explanation in #10.
Fix usage of "tableoid" in GENERATED expressions.
21 May 2021Tom Lanemaster14beta2REL_19_STABLE14beta2REL_18_STABLE14beta2REL_17_STABLE14beta2REL_16_STABLE14beta2REL_15_STABLE14beta2REL_14_STABLE14beta2REL_13_STABLE13.4+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #8

The tableoid component of #8 matches the commit's tablecmds.c and regression changes exactly apart from diff index metadata. The commit additionally initializes tts_tableOid before generated-column evaluation in the foreign-table ExecInsert and ExecUpdate paths in src/backend/executor/nodeModifyTable.c, implementing the gaps identified in #10.

Credits across 2 commits

Author
Tom LaneLLM2
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.