model-writtenrun 7441 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Vitaly Ustinov reported that generated expressions receiving whole rows stopped updating in PostgreSQL 13 and could crash ALTER TABLE when restored after an upgrade, although his PostgreSQL 12 installation appeared to work #1.
- Tom Lane supplied a tuple-initialization workaround but argued that whole-row references inherently violate the prohibition on generated-column self-dependencies #2; after David G. Johnston raised compatibility concerns #3, Tom reported the same assertion failure back to PostgreSQL 12 and emphasized the undefined behavior #4.
- Tom replaced the crash workaround with a patch rejecting whole-row references and all system columns, demonstrating that adding a generated tableoid column to existing rows produced zero #5.
- Vitaly explained why passing a whole row suited his hashing function and advocated allowing uncomputed generated values to appear as NULL, drawing comparisons with trigger behavior, while accepting triggers as a workaround #6 #7.
- After finding that the parser already rejects system columns except tableoid, Tom retained that exception and posted two patches: one fixing tableoid initialization during table rewrites, and another rejecting whole-row references with an explanatory error detail; he reported check-world passing but remained concerned about tableoid semantics #8.
- Vitaly questioned the whole-row restriction's consistency with BEFORE triggers #9; Tom explained the different evaluation context and identified additional tableoid initialization defects in foreign-table insert and update paths in the final thread reply #10.
- The tableoid patch from #8 landed with the additional foreign-table executor fixes described in #10 as 2b0ee126bb, with backports to PostgreSQL 12 and 13.
- The whole-row rejection component of #8 then landed unchanged as 4b10074453, also backported to PostgreSQL 12 and 13, completing both final patches while leaving the initial crash workaround and blanket tableoid prohibition superseded.