Feb 2022

3 commits
Move libpq's write_failed mechanism down to pqsecure_raw_write().
12 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #291 of 3 reviewers saw the final version

The commit takes the fe-misc.c and fe-secure.c changes from #29, changing only the pqSendSome() explanatory comment. Its my_sock_write() correction was split into 335fa5a260.

  • Andres Freundsaw the final versionLLM analysis, 99% sureIn #30, he reviewed the draft and requested clearer wording about reading server errors, which the committed comment incorporates.
  • Daniel Gustafssonsaw an earlier versionLLM analysis, 99% sureIn #25, he repeatedly tested #23 on Linux and OpenBSD and isolated EPIPE as sufficient to suppress the failures, before the mechanism was substantially reworked.
  • Thomas Munrosaw an earlier versionLLM analysis, 86% sureIn #18 and #20, he tested the diagnostic predecessor #15 and showed that removing its delay restored the failures, before the client-side redesign.
Fix thinko in PQisBusy().
12 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+1 more
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #350 of 1 reviewer saw the final version

The fe-exec.c hunk exactly matches #35. The commit additionally incorporates the my_sock_write() res <= 0 to res < 0 correction from #29, so errno is consulted only on failure.

  • Andres Freundsaw an earlier versionLLM analysis, 95% sureIn #30, he reviewed the included errno correction and identified the PQisBusy() bug, but the CONNECTION_BAD solution in #35 followed without a further visible review from him.
Set SNI ClientHello extension to localhost in tests
10 Feb 2022Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #151 of 1 reviewer saw the final version

All hunks in src/test/ssl/t/001_ssltests.pl, 002_scram.pl and 003_sslinfo.pl exactly match #15. The diagnostic server-side sleep in src/backend/libpq/be-secure-openssl.c is omitted.

  • Tom Lanesaw the final versiontrailerHe tested the patch in #21, traced the failures to invalid SNI hostnames in #22, and endorsed retaining localhost to exercise SNI in #26.

Credits across 3 commits

Author
Tom LaneLLM2
Daniel GustafssonLLM1
Reviewer
Tom Lane1
Reported by
Nazir Bilal Yavuz1
Committer
Tom Lane2
Daniel Gustafsson1

N LLM means N of the credits come from LLM analysis, not from commit trailers.