model-writtenrun 3681 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Mark Guertin reported that Finder-created .DS_Store files caused pg_basebackup to fail with an invalid-segment error, leaving manual deletion as his workaround #1.
- Tobias Bussmann suggested adding .DS_Store to the exclusion lists, while Tom Lane proposed ignoring all dot-prefixed files; Michael Paquier and Daniel Gustafsson initially supported the broader rule #2 #3 #4 #5.
- Daniel submitted hidden-file filtering for base backups and checksum scans #6, and Tobias and Michael persuaded him to include pg_rewind and regression tests despite his initial caution about changing recovery-tool behavior #7 #8 #9.
- Kyotaro Horiguchi questioned the separate and seemingly arbitrary exclusion checks, but Daniel defended their readability and Michael accepted keeping the ordering and avoiding noisy logging of temporary filenames #10 #12 #15.
- Daniel added pg_rewind support, tests, and documentation #11; Tobias verified the fix with TAP tests and an actual macOS reproduction, then supplied and refined the missing replication-protocol documentation #13 #14.
- Michael identified inconsistent treatment of temporary-directory patterns, prompting Daniel to add explicit checks and a test alongside the documentation refinements; Michael found that revision broadly sound #15 #16 #17.
- The backpatch discussion separated a broad behavior change from a targeted bugfix: Michael wanted relief for stable branches, Daniel initially viewed hidden-file exclusion as a feature, and Tobias argued that excluding .DS_Store specifically was a backpatchable correction #19 #20 #22.
- In July, Jacob Champion demonstrated that excluding all hidden files could omit an explicitly included configuration file, and Tom favored restricting the fix to .DS_Store even on the development branch #24 #25.
- Although Daniel and Michael still saw benefits in broader exclusion, Daniel identified consensus for skipping .DS_Store across branches and deferred the broader proposal, with Michael agreeing #26 #27 #28 #29.
- Daniel submitted the narrowed patch, removed the temporary-pattern changes, and guarded the synthetic .DS_Store tests against execution on macOS to avoid possible Finder side effects #30.
- Michael demonstrated that filtering pg_rewind's local directory traversal missed remote sources #31; Daniel moved the check into filemap.c and added the regression case #32, which Michael accepted along with the checksum and basebackup portions #33.
- After roughly six months, Daniel revived the patch with a functionally unchanged rebase and said he intended to commit after a cfbot cycle; this is the final supplied message, with the broader hidden-file proposal still deferred #34.
- The targeted fix subsequently landed on the development branch as c1fc502f59 from #34, with an expanded commit message and a test-payload wording change, and was backpatched through PostgreSQL 12.
- The supplied candidate 76bb6dd2e5 is that same change's PostgreSQL 12 backport rather than an independent landing; its adaptation places the rewind check in isRelDataFile(), unlike the development commit, and the supplied thread contains no subsequent discussion of that difference.