Nov 2024

5 commits
Require sizeof(bool) == 1.
27 Nov 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1
LLM analysis, 100% surelanded as postedfrom patchset #231 of 1 reviewer saw the final version

The complete diff matches #23 after normalizing hunk offsets and blob IDs, including bool fallback removal in c.h, ecpglib.h and plperl_system.h.

  • Tom Lanesaw the final versiontrailerTom said the patch passed an eyeball check in #24, while explicitly noting that he had not tested it.
If a C23 compiler is detected, try asking for C17.
27 Nov 2024Thomas MunroREL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19REL_12_STABLEunreleasedREL_11_STABLEunreleasedREL_10_STABLEunreleasedREL9_6_STABLEunreleasedREL9_5_STABLEunreleased+3 more
LLM analysis, 72% surelanded as postedfrom patchset #211 of 1 reviewer saw the final version

The configure.ac change tests __STDC_VERSION__ > 201710L and requests -std=gnu17, matching the submission described in #21 and its push announcement in #22. Unchanged application is inferred rather than verified because the attachments were not extracted.

  • Tom Lanesaw the final versionLLM analysis, 90% sureTom proposed automatic fallback to an older C standard in #17 and endorsed Thomas's conditional C17 design in #19, before the attachment was submitted.
Fix C23 compiler warning
26 Nov 2024Peter EisentrautREL_17_STABLE17.3REL_16_STABLE16.7Also in: Fix C23 compiler warning (modified before commit)
LLM analysis, 98% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The change adds struct forward declarations and an explicit amcostestimate prototype in src/include/nodes/pathnodes.h, absent from every attached patchset. It implements the backport work discussed in #11, #13 and #17.

  • Tom Lanesaw the final versiontrailerUnder the no-source coverage rule, Tom reviewed the last patchset in #24; that review concerns bool cleanup, while this thread contains no separate code review of the prototype backport.
Rename C23 keyword
26 Nov 2024Peter EisentrautREL_17_STABLE17.3REL_16_STABLE16.7Also in: Rename C23 keyword (landed as posted)
LLM analysis, 99% surewritten from the discussion, no matching patch0 of 1 reviewer saw the final version

The constexpr-to-const_expr rename in src/backend/optimizer/util/predtest.c is not in an attached patchset. Its backport follows Peter's proposal in #11 and the decision to support C23 on PostgreSQL 16 and later in #17.

  • Robert Haasno review foundtrailerRobert did not post in this thread; the commit carries review credit alongside a Discussion link to the original development thread.
Assume that <stdbool.h> conforms to the C standard.
25 Nov 2024Thomas Munromaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3REL_16_STABLE16.7REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19+2 more
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #90 of 2 reviewers saw the final version

This implements only the conformance-check fix from #9, leaving the dfmgr.c cleanup for later. The supplied commit is the PostgreSQL 11 adaptation described in #14: configure.in retains a stdbool.h presence check through AC_CHECK_HEADERS, with corresponding configuration-header changes.

  • Peter Eisentrautsaw an earlier versiontrailerPeter reported successful GCC 14 C23 builds for PostgreSQL 16 and later in #13 and identified older branches' C89 constraint, before the PostgreSQL 11 presence-check adaptation.
  • Tom Lanesaw an earlier versiontrailerTom shaped the bool-size-only approach in #6 and #8 and discussed the submitted cleanup in #10, without reviewing the later PostgreSQL 11 adaptation here.

Credits across 5 commits

Author
Thomas MunroLLM2
Reviewer
Tom Lane3
Peter Eisentraut1
Robert Haas1
Reported by
Sam James1
Committer
Thomas Munro3
Peter Eisentraut2

N LLM means N of the credits come from LLM analysis, not from commit trailers.