Jan 2025

2 commits
Fix HBA option count
12 Jan 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3REL_16_STABLE16.7REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit raises MAX_HBA_OPTIONS from 14 to 15 and updates the LDAP option count comment in src/backend/libpq/hba.c, exactly addressing Tom Lane's report in #7. Neither attachment contains these changes; Daniel Gustafsson promises the correction in #8.

  • Tom Lanesaw the final versionLLM analysis, 99% sureIn #7, he reports Coverity's overrun warning against the landed patch and identifies both the missing MAX_HBA_OPTIONS increase and the comment correction implemented by this commit.
Fix missing ldapscheme option in pg_hba_file_rules()
10 Jan 2025Daniel Gustafssonmaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3REL_16_STABLE16.7REL_15_STABLE15.11REL_14_STABLE14.16REL_13_STABLE13.19
LLM analysis, 99% surelanded as postedfrom patchset #31 of 1 reviewer saw the final version

The commit contains the identical four-line ldapscheme insertion from #3, applied to gethba_options() in src/backend/libpq/hba.c instead of get_hba_options() in src/backend/utils/adt/hbafuncs.c. The path and function context differ, but the added logic is unchanged.

  • Daniel Gustafssonsaw the final versiontrailerHe says LGTM in #4, confirms his intention to commit in #6, and is the committer of the final version.

Credits across 2 commits

Author
Laurenz Albe1
Reviewer
Daniel Gustafsson1
Reported by
Laurenz Albe1
Tom Lane1
Committer
Daniel Gustafsson2