Re: [PORTS] Port Bug Report: pg_dump -d database >unload.file; cat unload.file|psql database ARE NOT EQUAL

Problem Description:
--------------------
Parser generated error message when script was inserting
a value equal -1 into column of float8 type.
If exchange -1 to -1.0 - no errors.

--------------------------------------------------------------------------

Test Case:
----------
create table templ_arg(accii int2,type char,sign float8);
create table a1 () inherits (templ_arg);
insert into a1 values (9999,'a',1); -- working;
insert into a1 values (9999,'a',-1); -- ERROR;
insert into a1 values (9999,'a',-1.0); --working

OK, it is more compilcated that I realized. I now see that:

insert into a1 values (9999,'a',1); -- working;

works but:

insert into a1 values (9999,'a',-1); -- ERROR;

does not. Thomas, any idea why this would happen?

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

create table templ_arg(accii int2,type char,sign float8);
create table a1 () inherits (templ_arg);
insert into a1 values (9999,'a',1); -- working;
insert into a1 values (9999,'a',-1); -- ERROR;
insert into a1 values (9999,'a',-1.0); --working

Looking at the grammar, I think that -1 is being interpreted as the
expression minus and 1, as in (no_expression - 1), and the complaint is
that that expression is not a float8. We already have code to promote
constants to float4. Thomas will have to comment, because he
understands the handling of the minuses.

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

create table templ_arg(accii int2,type char,sign float8);
create table a1 () inherits (templ_arg);
insert into a1 values (9999,'a',1); -- working;
insert into a1 values (9999,'a',-1); -- ERROR;
insert into a1 values (9999,'a',-1.0); --working

Yep, the problem gram.y line is:

| '-' a_expr %prec UMINUS
{ $$ = makeA_Expr(OP, "-", NULL, $2);}

This is being executed rather than the code that reads in negative
integer constants.

-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

create table templ_arg(accii int2,type char,sign float8);
create table a1 () inherits (templ_arg);
insert into a1 values (9999,'a',1); -- working;
insert into a1 values (9999,'a',-1); -- ERROR;
insert into a1 values (9999,'a',-1.0); --working

Yep, the problem gram.y line is:

| '-' a_expr %prec UMINUS
{ $$ = makeA_Expr(OP, "-", NULL, $2);}

This is being executed rather than the code that reads in negative
integer constants.

Yes. It's a problem because the scanner assigned types to integer and
floating point constants, but does not have a sense of context so the
negative sign must be stripped off since it could be in the middle of a
math expression. We will need to fix this in gram.y or by using the new
type conversion stuff farther back. But, I don't know how much new type
conversion capabilities there will be until I've tried to address most
of the pieces; still working out lingering problems in the function call
portion.

Will put this one on my list of things to look at.

- Tom