Re: ?Missing '#define FUNC_MAX_ARGS' in pg_config.h.win32?

Started by Bruce Momjianover 23 years ago4 messages

pgman@candle.pha.pa.us

over 23 years ago

1 attachment(s)

Based on this report, I am adding a FUNC_MAX_ARGS define to
src/include/pg_config.h.win32. Certainly if we have INDEX_MAX_KEYS in
there, we should have FUNC_MAX_ARGS too.

---------------------------------------------------------------------------

Chris Ryan wrote:

Bruce,

I'm not active on the pgsql lists so I figured I would pass this on to
you.

We were working on compiling some apps using the libpq interface on
windows and ran into a problem where FUNC_MAX_ARGS was not defined in
the src/include/pg_config.h.win32 file. We added the following line to
the file:

#define FUNC_MAX_ARGS INDEX_MAX_KEYS

After an nmake -f win32.mak cleanl; nmake -f win32.mak everything
worked fine.

Thanks in advance.
Chris

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Attachments:

/bjm/difftext/plainDownload

Index: src/include/pg_config.h.win32
===================================================================
RCS file: /cvsroot/pgsql/src/include/pg_config.h.win32,v
retrieving revision 1.3
diff -c -r1.3 pg_config.h.win32
*** src/include/pg_config.h.win32	22 Jan 2002 19:02:40 -0000	1.3
--- src/include/pg_config.h.win32	23 Apr 2002 23:42:59 -0000
***************
*** 19,24 ****
--- 19,25 ----
  #define BLCKSZ	8192
  
  #define INDEX_MAX_KEYS		16
+ #define FUNC_MAX_ARGS		INDEX_MAX_KEYS
  
  #define HAVE_ATEXIT
  #define HAVE_MEMMOVE

Import Notes

Reply to msg id not found: 3CC43591.4BDD8C79@yahoo.com

Peter Eisentraut

peter_e@gmx.net

over 23 years ago

In reply to: Bruce Momjian (#1)

Bruce Momjian writes:

Based on this report, I am adding a FUNC_MAX_ARGS define to
src/include/pg_config.h.win32. Certainly if we have INDEX_MAX_KEYS in
there, we should have FUNC_MAX_ARGS too.

We probably shouldn't have either one in there.

--
Peter Eisentraut peter_e@gmx.net

Bruce Momjian

pgman@candle.pha.pa.us

over 23 years ago

In reply to: Peter Eisentraut (#2)

Peter Eisentraut wrote:

Bruce Momjian writes:

Based on this report, I am adding a FUNC_MAX_ARGS define to
src/include/pg_config.h.win32. Certainly if we have INDEX_MAX_KEYS in
there, we should have FUNC_MAX_ARGS too.

We probably shouldn't have either one in there.

I thought so too, but the reporter complained something didn't compile
without it. What should we do?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Peter Eisentraut

peter_e@gmx.net

over 23 years ago

In reply to: Bruce Momjian (#3)

Bruce Momjian writes:

Peter Eisentraut wrote:

Bruce Momjian writes:

Based on this report, I am adding a FUNC_MAX_ARGS define to
src/include/pg_config.h.win32. Certainly if we have INDEX_MAX_KEYS in
there, we should have FUNC_MAX_ARGS too.

We probably shouldn't have either one in there.

I thought so too, but the reporter complained something didn't compile
without it. What should we do?

I'm working right now on removing traces of FUNC_MAX_ARGS, INDEX_MAX_KEYS,
and NAMEDATALEN from frontend code (pg_dump and psql). When I'm done I
will remove the definition from pg_config.h.win32.

--
Peter Eisentraut peter_e@gmx.net