Mar 2026

8 commits
Fix outdated comment on MainLWLockArray
30 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #101 of 1 reviewer saw the final version

The commit implements the MainLWLockArray comment cleanup attached in #10, shortening its proposed replacement to a single-line comment in src/backend/storage/lmgr/lwlock.c.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Fix RequestNamedLWLockTranche in single-user mode
27 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% surelanded as postedfrom patchset #131 of 2 reviewers saw the final version

Both hunks exactly match #13: RequestNamedLWLockTranche() selects PostmasterContext or TopMemoryContext, allocates the request and list there, and restores the previous context.

  • Andres Freundsaw an earlier versionLLM analysis, 91% sureAndres reported the single-user pg_rewind assertion caused by the landed refactoring in #11, before Nathan supplied the memory-context correction in #13.
  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Minor comment fixes to yesterday's LWLock tranche refactoring
27 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #81 of 1 reviewer saw the final version

The commit retains all four comment fixes from #8, but describes InitializeLWLocks() as initializing built-in tranches and those requested with RequestNamedLWLockTranche(), and rewraps another comment; Heikki explains the wording in #9.

  • Heikki Linnakangassaw the final versioncommittercommitted the patch
Move ShmemIndexLock into ShmemAllocator
26 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 97% surepart of a posted patchsetmoderate changesfrom patchset #10 of 1 reviewer saw the final version

The commit takes the ShmemAllocator lock relocation and wait-event changes from the final attachment in #1, with comment edits. Its BackendParameters removals instead land in 30d432502b, and reordering makes its conditional-locking reversals unnecessary.

  • Nathan Bossartsaw an earlier versiontrailerNathan identified the redundant locking changes and requested reordering in #2, before this attachment was split and committed ahead of the ShmemInitStruct conversion.
Use ShmemInitStruct to allocate lwlock.c's shared memory
26 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #10 of 1 reviewer saw the final version

This derives from the ShmemInitStruct attachment in #1, with the MainLWLockArray BackendParameters removals moved here from the final attachment. Reordering the allocator-lock change first eliminates the proposed conditional locking changes in src/backend/storage/ipc/shmem.c.

  • Nathan Bossartsaw an earlier versiontrailerNathan questioned the startup locking assumptions and proposed reordering the last two patches in #2, before their locking and BackendParameters hunks were redistributed.
Use a separate spinlock to protect LWLockTranches
26 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The separate-spinlock attachment in #1 supplies the implementation unchanged; the commit fixes the ShmemSegHdr comment grammar and condenses the spinlock comment in LWLockNewTrancheId().

  • Nathan Bossartsaw the final versiontrailerNathan reviewed the separate-spinlock patch as fine in #2, and only comment edits followed.
Refactor how user-defined LWLock tranches are stored in shmem
26 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The shared-memory refactoring matches the second attachment in #1, with foreach_ptr substitutions requested in #2, a loop-local declaration, formatting fixes, and clarified comments in src/backend/storage/lmgr/lwlock.c.

  • Nathan Bossartsaw the final versiontrailerNathan reviewed the refactoring, requested foreach_ptr and clearer comments, and discussed atomic access in #2, with only equivalent loop cleanup and editorial changes before landing.
Rename MAX_NAMED_TRANCHES to MAX_USER_DEFINED_TRANCHES
26 Mar 2026Heikki Linnakangasmaster19beta1REL_19_STABLE19beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The rename matches the first attachment in #1, with additional terminology cleanup in the LWLockShmemSize() and CreateLWLocks() comments and a rewritten commit explanation.

  • Nathan Bossartsaw the final versiontrailerNathan accepted the terminology patch in #2, before only editorial changes were made.
  • Sami Imseihsaw the final versiontrailerSami explicitly reviewed the first attachment and supported user-defined terminology while proposing broader API renaming in #4.

Credits across 8 commits

Author
Heikki LinnakangasLLM5
Sami Imseih1 LLM2
Nathan Bossart1
Reviewer
Nathan Bossart5
Heikki Linnakangascommitter3
Sami Imseih1
Reported by
Sami Imseih1
Committer
Heikki Linnakangas8

N LLM means N of the credits come from LLM analysis, not from commit trailers.