RC1?

Started by Bruce Momjianover 23 years ago86 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

Are we ready for RC1 yet?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: RC1?

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Are we ready for RC1 yet?

I think so. The NO_MKTIME_BEFORE_1970 issue was bothering me, but I
feel that's resolved now. (It'd be nice to hear a crosscheck from
some AIX users though...)

regards, tom lane

#3Vince Vielhaber
vev@michvhf.com
In reply to: Bruce Momjian (#1)
Re: RC1?

On Tue, 12 Nov 2002, Bruce Momjian wrote:

Are we ready for RC1 yet?

This is Tuesday, you can only ask on Fridays :)

Vince.
--
http://www.meanstreamradio.com http://www.unknown-artists.com
Internet radio: It's not file sharing, it's just radio.

#4Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: Bruce Momjian (#1)
Re: RC1?

Are we ready for RC1 yet?

I'm waiting for jenny wang confirms the fix regarding GB18030
support. In the mean time, I'll commit the fix anyway since current
GB183030 support is so badly broken (I have checked all regression
tests have passed).
--
Tatsuo Ishii

#5The Hermit Hacker
scrappy@hub.org
In reply to: Tatsuo Ishii (#4)
Re: RC1?

'K, looks like we need two things confirmed ... the change that Tom made
concerning mktime(), which we need someone on AIX to test ... and the
following ...

I've been following the commit messages closely, and haven't seen anything
go in that make me edgy, so if we can get validation on those two, I think
we're good to go ...

On Tue, 12 Nov 2002, Tatsuo Ishii wrote:

Show quoted text

Are we ready for RC1 yet?

I'm waiting for jenny wang confirms the fix regarding GB18030
support. In the mean time, I'll commit the fix anyway since current
GB183030 support is so badly broken (I have checked all regression
tests have passed).
--
Tatsuo Ishii

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

#6Zeugswetter Andreas SB SD
ZeugswetterA@spardat.at
In reply to: The Hermit Hacker (#5)
Re: RC1?

Are we ready for RC1 yet?

I think so. The NO_MKTIME_BEFORE_1970 issue was bothering me, but I
feel that's resolved now. (It'd be nice to hear a crosscheck from
some AIX users though...)

abstime, tinterval and horology fail on AIX.
The rest is now working (AIX 4.3.2 xlc 5.0.0.2).

I am just now rebuilding with removing the #define NO_MKTIME_BEFORE_1970.
My feeling is, that there is no difference. Can that be ?
Attached are the regression diffs for vanilla 7.3b5

Andreas

Attachments:

regression.diffs.gzapplication/x-gzip; name=regression.diffs.gzDownload
#7Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zeugswetter Andreas SB SD (#6)
Re: RC1?

"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:

abstime, tinterval and horology fail on AIX.=20

I would expect them now (without NO_MKTIME_BEFORE_1970) to match the
solaris-1947 comparison files for these tests. Could you confirm that?

regards, tom lane

#8Zeugswetter Andreas SB SD
ZeugswetterA@spardat.at
In reply to: Tom Lane (#7)
Re: RC1?

I think so. The NO_MKTIME_BEFORE_1970 issue was bothering me, but I
feel that's resolved now. (It'd be nice to hear a crosscheck from
some AIX users though...)

abstime, tinterval and horology fail on AIX.
The rest is now working (AIX 4.3.2 xlc 5.0.0.2).

I am just now rebuilding with removing the #define NO_MKTIME_BEFORE_1970.

Ok, when #define NO_MKTIME_BEFORE_1970 is removed from aix.h, then the results
match the Solaris files.

Attached is a patch to make AIX match Solaris. Please apply and add AIX to
the supported platforms.

Thank you
Andreas

PS: what should we do with the rest of the resultmap entries for no-DST-before-1970 ?

Attachments:

aix.mktimerm.patch.gzapplication/x-gzip; name=aix.mktimerm.patch.gzDownload
#9Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zeugswetter Andreas SB SD (#8)
Re: RC1?

"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:

Ok, when #define NO_MKTIME_BEFORE_1970 is removed from aix.h, then the
results match the Solaris files.

Great!

Attached is a patch to make AIX match Solaris. Please apply and add AIX
to the supported platforms.

Patch applied to 7.3 and CVS tip --- Bruce, you're maintaining the
supported-platforms list, right?

PS: what should we do with the rest of the resultmap entries for
no-DST-before-1970 ?

I can tell you that the hppa entry is correct. I presume the cygwin
folks would've mentioned it by now if theirs wasn't.

I suspect we are looking at two different behaviors for systems with no
old DST data: either assume all before 1970 is standard time (hppa does
this) or assume that years before 1970 use the same transition rule as
1970 (I'll bet that's what Solaris, AIX, etc are doing).

regards, tom lane

#10Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#9)
Re: RC1?

Tom Lane wrote:

"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:

Ok, when #define NO_MKTIME_BEFORE_1970 is removed from aix.h, then the
results match the Solaris files.

Great!

Attached is a patch to make AIX match Solaris. Please apply and add AIX
to the supported platforms.

Patch applied to 7.3 and CVS tip --- Bruce, you're maintaining the
supported-platforms list, right?

AIX updated in 7.3 and CVS.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#11Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#1)
Re: RC1?

Bruce Momjian writes:

Are we ready for RC1 yet?

Questionable. We don't even have 50% confirmation coverage for the
supported platforms yet.

--
Peter Eisentraut peter_e@gmx.net

#12Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#11)
Re: RC1?

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

Are we ready for RC1 yet?

Questionable. We don't even have 50% confirmation coverage for the
supported platforms yet.

We can't just wait around indefinitely for port reports that may or may
not ever appear. In any case, most of the "<7.3" entries in the list
seem to be various flavors of *BSD; I think it's unlikely we broke
those ...

regards, tom lane

#13Robert Treat
xzilla@users.sourceforge.net
In reply to: Tom Lane (#12)
Re: RC1?

On Tue, 2002-11-12 at 16:27, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

Are we ready for RC1 yet?

Questionable. We don't even have 50% confirmation coverage for the
supported platforms yet.

We can't just wait around indefinitely for port reports that may or may
not ever appear. In any case, most of the "<7.3" entries in the list
seem to be various flavors of *BSD; I think it's unlikely we broke
those ...

Why not send an email to the folks who last reported a supported
platform and ask for an update? Probably won't get through to everyone,
but it might help pare down the list of unconfirmed.

Robert Treat

#14scott.marlowe
scott.marlowe@ihs.com
In reply to: Robert Treat (#13)
Re: RC1?

On 12 Nov 2002, Robert Treat wrote:

On Tue, 2002-11-12 at 16:27, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

Are we ready for RC1 yet?

Questionable. We don't even have 50% confirmation coverage for the
supported platforms yet.

We can't just wait around indefinitely for port reports that may or may
not ever appear. In any case, most of the "<7.3" entries in the list
seem to be various flavors of *BSD; I think it's unlikely we broke
those ...

Why not send an email to the folks who last reported a supported
platform and ask for an update? Probably won't get through to everyone,
but it might help pare down the list of unconfirmed.

I'm testing x86 solaris right now. It's turning into a giant pain because
of how the box I'm on is configured.

#15scott.marlowe
scott.marlowe@ihs.com
In reply to: Robert Treat (#13)
Re: RC1?

On 12 Nov 2002, Robert Treat wrote:

On Tue, 2002-11-12 at 16:27, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Bruce Momjian writes:

Are we ready for RC1 yet?

Questionable. We don't even have 50% confirmation coverage for the
supported platforms yet.

We can't just wait around indefinitely for port reports that may or may
not ever appear. In any case, most of the "<7.3" entries in the list
seem to be various flavors of *BSD; I think it's unlikely we broke
those ...

Why not send an email to the folks who last reported a supported
platform and ask for an update? Probably won't get through to everyone,
but it might help pare down the list of unconfirmed.

I get this for gmake check:

(Lotsa messages deleted):

============== removing existing temp installation ==============
============== creating temporary installation ==============
============== initializing database system ==============
============== starting postmaster ==============
running on port 65432 with pid 19771
============== creating database "regression" ==============
CREATE DATABASE
ALTER DATABASE
============== dropping regression test user accounts ==============
============== installing PL/pgSQL ==============
============== running regression test queries ==============
parallel group (13 tests): float4 int8 text int2 oid int4 char boolean
varchar name float8 bit numeric boolean ... ok
char ... ok
name ... ok
varchar ... ok
text ... ok
int2 ... ok
int4 ... ok
int8 ... ok
oid ... ok
float4 ... ok
float8 ... ok
bit ... ok
numeric ... ok
============== shutting down postmaster ==============

======================
All 13 tests passed.
======================

rm regress.o
gmake[2]: Leaving directory
`/home/smarlowe/postgresql-7.3b5/src/test/regress'
gmake[1]: Leaving directory `/home/smarlowe/postgresql-7.3b5/src/test'

(END QUOTE)

And then it stops. Anyone know why it doesn't run the rest of the
regresssion tests?

#16scott.marlowe
scott.marlowe@ihs.com
In reply to: scott.marlowe (#15)
Re: RC1?

On Tue, 12 Nov 2002, Tom Lane wrote:

"scott.marlowe" <scott.marlowe@ihs.com> writes:

And then it stops. Anyone know why it doesn't run the rest of the
regresssion tests?

Somebody else just reported the same thing on Solaris. Must be
something about the pg_regress script that doesn't play nicely with
Solaris' shell. Can you poke into it and try to figure out what?
(Perhaps running the script with +x would help.)

will do.

#17scott.marlowe
scott.marlowe@ihs.com
In reply to: scott.marlowe (#16)
Re: RC1?

On Tue, 12 Nov 2002, Tom Lane wrote:

"scott.marlowe" <scott.marlowe@ihs.com> writes:

And then it stops. Anyone know why it doesn't run the rest of the
regresssion tests?

Somebody else just reported the same thing on Solaris. Must be
something about the pg_regress script that doesn't play nicely with
Solaris' shell. Can you poke into it and try to figure out what?
(Perhaps running the script with +x would help.)

OK, make -x check fails, is there some other way to use -x I'm not
thinking of here?

#18Tom Lane
tgl@sss.pgh.pa.us
In reply to: scott.marlowe (#15)
Re: RC1?

"scott.marlowe" <scott.marlowe@ihs.com> writes:

And then it stops. Anyone know why it doesn't run the rest of the
regresssion tests?

Somebody else just reported the same thing on Solaris. Must be
something about the pg_regress script that doesn't play nicely with
Solaris' shell. Can you poke into it and try to figure out what?
(Perhaps running the script with +x would help.)

regards, tom lane

#19Tom Lane
tgl@sss.pgh.pa.us
In reply to: scott.marlowe (#17)
Re: RC1?

"scott.marlowe" <scott.marlowe@ihs.com> writes:

OK, make -x check fails, is there some other way to use -x I'm not
thinking of here?

I was thinking of running the script by hand, not via make:

/bin/sh -x ./pg_regress --temp-install --top-builddir=../../.. --schedule=./parallel_schedule --multibyte=SQL_ASCII

regards, tom lane

#20scott.marlowe
scott.marlowe@ihs.com
In reply to: Tom Lane (#19)
Re: RC1?

On Tue, 12 Nov 2002, Tom Lane wrote:

"scott.marlowe" <scott.marlowe@ihs.com> writes:

OK, make -x check fails, is there some other way to use -x I'm not
thinking of here?

I was thinking of running the script by hand, not via make:

/bin/sh -x ./pg_regress --temp-install --top-builddir=../../.. --schedule=./parallel_schedule --multibyte=SQL_ASCII

Ok, now that I've run it that way, the last couple of pages of output
look like this:

formatted=numeric
+ echo      numeric              ... \c
EXPECTED=./expected/numeric
     numeric              ... + expr abstime=abstime-solaris-1947 : 
numeric=
+ [ 0 -ne 0 ]
+ expr geometry=geometry-solaris-i386-pc : numeric=
+ [ 0 -ne 0 ]
+ expr horology=horology-solaris-1947 : numeric=
+ [ 0 -ne 0 ]
+ expr tinterval=tinterval-solaris-1947 : numeric=
+ [ 0 -ne 0 ]
bestfile=
bestdiff=
result=2
+ [ ! -r ./expected/numeric.out ]
+ diff -w ./expected/numeric.out ./results/numeric.out
result=0
+ break
+ echo ok
ok
+ read line
+ [ 0 -ne 0 ]
+ [ -n 22844 ]
+ message shutting down postmaster
_dashes===============
_spaces=
+ cut -c 1-38
+ echo shutting down postmaster
_msg=shutting down postmaster
+ echo ============== shutting down postmaster               
==============
============== shutting down postmaster               ==============
+ kill -15 22844
+ unset postmaster_pid
+ rm -f /tmp/pg_regress.19030
+ cat ./regression.out
+ grep \.\.\.
+ sed s/ //g
+ wc -l
count_total=13
+ cat ./regression.out
+ grep \.\.\. ok
+ + wc -l sed
 s/ //g
count_ok=13
+ cat ./regression.out
+ sed s/ //g
+ wc -l
+ grep \.\.\. FAILED
count_failed=0
+ cat ./regression.out
+ grep \.\.\. failed (ignored)
+ sed s/ //g
+ wc -l
count_ignored=0
+ echo
+ [ 13 -eq 13 ]
msg=All 13 tests passed.
result=0
+ sed s/./=/g
+ echo  All 13 tests passed.
dashes=======================
+ echo ======================
======================
+ echo  All 13 tests passed.
 All 13 tests passed.
+ echo ======================
======================
+ echo
+ [ -s ./regression.diffs ]
+ rm -f ./regression.diffs ./regression.out
+ exit 0
+ exit
savestatus=0
+ [ -n  ]
+ rm -f /tmp/pg_regress.19030
+ exit 0

Hope that helps.

#21Tom Lane
tgl@sss.pgh.pa.us
In reply to: scott.marlowe (#20)
#22Nigel J. Andrews
nandrews@investsystems.co.uk
In reply to: Tom Lane (#12)
#23Zeugswetter Andreas SB SD
ZeugswetterA@spardat.at
In reply to: Nigel J. Andrews (#22)
#24Tom Lane
tgl@sss.pgh.pa.us
In reply to: Zeugswetter Andreas SB SD (#23)
#25Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tom Lane (#24)
#26scott.marlowe
scott.marlowe@ihs.com
In reply to: Tom Lane (#21)
#27Chris Browne
cbbrowne@acm.org
In reply to: Tom Lane (#24)
#28Tom Lane
tgl@sss.pgh.pa.us
In reply to: Nigel J. Andrews (#22)
#29Nigel J. Andrews
nandrews@investsystems.co.uk
In reply to: Tom Lane (#28)
#30Tom Lane
tgl@sss.pgh.pa.us
In reply to: Nigel J. Andrews (#29)
#31Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#12)
#32Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Peter Eisentraut (#31)
#33Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: Tom Lane (#28)
#34Bruce Momjian
bruce@momjian.us
In reply to: Nigel J. Andrews (#22)
#35Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#31)
#36Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#35)
#37Bruce Momjian
bruce@momjian.us
In reply to: Nigel J. Andrews (#29)
#38Bruce Momjian
bruce@momjian.us
In reply to: Christopher Kings-Lynne (#32)
#39Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christopher Kings-Lynne (#33)
#40Neil Conway
neilc@samurai.com
In reply to: Bruce Momjian (#36)
#41Bruce Momjian
bruce@momjian.us
In reply to: Neil Conway (#40)
#42Justin Clift
justin@postgresql.org
In reply to: Peter Eisentraut (#31)
In reply to: Peter Eisentraut (#31)
In reply to: Peter Eisentraut (#31)
#45Tom Lane
tgl@sss.pgh.pa.us
In reply to: Magnus Naeslund(f) (#44)
In reply to: Peter Eisentraut (#31)
#47Bruce Momjian
bruce@momjian.us
In reply to: Magnus Naeslund(f) (#46)
In reply to: Bruce Momjian (#47)
#49Bruce Momjian
bruce@momjian.us
In reply to: Magnus Naeslund(f) (#48)
#50Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Peter Eisentraut (#31)
#51Bruce Momjian
bruce@momjian.us
In reply to: Patrick Welche (#50)
#52Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Patrick Welche (#50)
#53Scott Lamb
slamb@slamb.org
In reply to: Peter Eisentraut (#31)
#54Matthew T. O'Connor
matthew@zeut.net
In reply to: Justin Clift (#42)
#55Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Tom Lane (#45)
#56Tom Lane
tgl@sss.pgh.pa.us
In reply to: Patrick Welche (#55)
#57Bruce Momjian
bruce@momjian.us
In reply to: Patrick Welche (#55)
#58Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Tom Lane (#56)
#59Peter Eisentraut
peter_e@gmx.net
In reply to: Bruce Momjian (#57)
#60Bruce Momjian
bruce@momjian.us
In reply to: Peter Eisentraut (#59)
#61Tom Lane
tgl@sss.pgh.pa.us
In reply to: Patrick Welche (#58)
#62Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#61)
#63Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#62)
#64Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Peter Eisentraut (#59)
#65Bruce Momjian
bruce@momjian.us
In reply to: Patrick Welche (#64)
#66Ken Hirsch
kahirsch@bellsouth.net
In reply to: Bruce Momjian (#62)
#67Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#61)
#68Henry B. Hotz
hotz@jpl.nasa.gov
In reply to: Tom Lane (#63)
#69Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Peter Eisentraut (#67)
#70Tom Lane
tgl@sss.pgh.pa.us
In reply to: Patrick Welche (#69)
#71Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#67)
#72Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Tom Lane (#70)
#73Tom Lane
tgl@sss.pgh.pa.us
In reply to: Patrick Welche (#72)
#74Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Tom Lane (#73)
#75Tom Lane
tgl@sss.pgh.pa.us
In reply to: Patrick Welche (#74)
#76Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Bruce Momjian (#65)
#77Patrick Welche
prlw1@newn.cam.ac.uk
In reply to: Bruce Momjian (#65)
#78Bruce Momjian
bruce@momjian.us
In reply to: Patrick Welche (#76)
#79Henry B. Hotz
hotz@jpl.nasa.gov
In reply to: Tom Lane (#73)
#80scott.marlowe
scott.marlowe@ihs.com
In reply to: Tom Lane (#19)
#81Bruce Momjian
bruce@momjian.us
In reply to: scott.marlowe (#80)
#82Christopher Kings-Lynne
chriskl@familyhealth.com.au
In reply to: scott.marlowe (#80)
#83scott.marlowe
scott.marlowe@ihs.com
In reply to: Bruce Momjian (#81)
#84Bruce Momjian
bruce@momjian.us
In reply to: scott.marlowe (#83)
#85scott.marlowe
scott.marlowe@ihs.com
In reply to: Christopher Kings-Lynne (#82)
#86scott.marlowe
scott.marlowe@ihs.com
In reply to: Christopher Kings-Lynne (#82)