Refactor code around GUC default_toast_compression

2 patchsets tracked - current t139530_6

v6t139530_6posted 6 days agosuccessneeds rebaserecent 5dpg 20

base6547a2f6c 6 days ago on master

applyapplied 6 days ago

rebaselast tried about 1 hour ago on 9e17d25e7

Applying: Refactor some code logic around GUC default_toast_compression
Using index info to reconstruct a base tree...
M	contrib/amcheck/verify_heapam.c
M	src/backend/access/common/detoast.c
M	src/backend/access/common/toast_compression.c
M	src/backend/access/common/toast_internals.c
M	src/backend/utils/adt/varlena.c
M	src/include/varatt.h
M	src/tools/pgindent/typedefs.list
Falling back to patching base and 3-way merge...
Auto-merging src/tools/pgindent/typedefs.list
Auto-merging src/include/varatt.h
Auto-merging src/backend/utils/adt/varlena.c
Auto-merging src/backend/access/common/toast_internals.c
Auto-merging src/backend/access/common/toast_compression.c
Auto-merging src/backend/access/common/detoast.c
Auto-merging contrib/amcheck/verify_heapam.c
CONFLICT (content): Merge conflict in contrib/amcheck/verify_heapam.c
Patch failed at 0001 Refactor some code logic around GUC default_toast_compression

error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

conflicts on master: contrib/amcheck/verify_heapam.c

push6 days ago -> 47960535b branch diff vs base

patchsetdownload in thread

Result	Att	PG	Tests	Build / test	Image	When
success	1	20	1036 / 1036	2m 52s / 5m 07s	`docker run ... :t139530`	6 days ago
run 34851706217 executed 1036 - ccache 98 hit / 6523 miss - head 47960535b - digest sha256:0a64181f95ae00... - run 34851706217

v5t139530_5posted May 11, 08:06successsupersededrecent 6dpg 20

base0c5d62696 Sep 13, 12:06 on master

applyapplied 7 days ago

rebaselast tried 7 days ago on 0c5d62696

push7 days ago -> 75337acf2 branch diff vs base

patchsetdownload in thread

Result	Att	PG	Tests	Build / test	Image	When
success	1	20	1023 / 1023	2m 55s / 5m 29s	`docker run ... @sha256:d7c8114...`	7 days ago
run 34792160693 executed 1023 - ccache 98 hit / 6523 miss - head 75337acf2 - digest sha256:d7c81147436f35... - run 34792160693
success	1	20	1023 / 1023	2m 54s / 5m 33s	`docker run ... @sha256:e602a83...`	Sep 13, 00:26
run 34727477703 executed 1023 - ccache 98 hit / 6523 miss - head 9e9f2b6eb - digest sha256:e602a831b30c50... - run 34727477703
success	1	20	1023 / 1023	2m 50s / 5m 06s	`docker run ... @sha256:81e677c...`	Sep 12, 00:23
run 34660900627 executed 1023 - ccache 98 hit / 6523 miss - head bdb7ff68f - digest sha256:81e677c214bea6... - run 34660900627
success	1	20	1022 / 1022	2m 47s / 5m 02s	`docker run ... @sha256:2fefeae...`	Sep 11, 00:21
run 34545427973 executed 1022 - ccache 98 hit / 6523 miss - head c397d4a8b - digest sha256:2fefeae91ea754... - run 34545427973
success	1	20	1021 / 1021	2m 13s / 4m 34s	`docker run ... @sha256:493c371...`	Sep 10, 00:20
run 34420164155 executed 1021 - ccache 98 hit / 6523 miss - head ce449382c - digest sha256:493c37146a394e... - run 34420164155
success	1	20	1020 / 1020	2m 44s / 4m 50s	`docker run ... @sha256:5921560...`	Sep 09, 00:18
run 34293742368 executed 1020 - ccache 98 hit / 6523 miss - head 94fc28e7c - digest sha256:592156084eead0... - run 34293742368
success	1	20	1020 / 1020	2m 47s / 5m 19s	`docker run ... @sha256:22e9f61...`	Sep 08, 00:18
run 34172243485 executed 1020 - ccache 98 hit / 6523 miss - head 199f2a525 - digest sha256:22e9f614eda96c... - run 34172243485
success	1	20	1024 / 1024	2m 10s / 4m 39s	`docker run ... @sha256:6e7b3e6...`	Sep 07, 00:18
run 34068555631 executed 1024 - ccache 98 hit / 6527 miss - head 23afd76f9 - digest sha256:6e7b3e6552a120... - run 34068555631
success	1	20	1024 / 1024	2m 54s / 5m 11s	`docker run ... @sha256:eb5d661...`	Sep 05, 01:30
run 33935811106 executed 1024 - ccache 98 hit / 6527 miss - head 5140166d9 - digest sha256:eb5d6617961b88... - run 33935811106
success	1	20	1024 / 1024	2m 55s / 5m 17s	`docker run ... @sha256:fb1f2e4...`	Sep 04, 01:29
run 33825274067 executed 1024 - ccache 98 hit / 6527 miss - head 68519f21d - digest sha256:fb1f2e4ad2a971... - run 33825274067
success	1	20	1022 / 1022	2m 55s / 5m 37s	`docker run ... @sha256:36d4eea...`	Sep 03, 01:27
run 33703003686 executed 1022 - ccache 98 hit / 6526 miss - head aa6b8e0b2 - digest sha256:36d4eeae39808b... - run 33703003686
success	1	20	1022 / 1022	2m 48s / 4m 39s	`docker run ... @sha256:470a843...`	Sep 02, 01:25
run 33578653745 executed 1022 - ccache 98 hit / 6526 miss - head 33ff659b9 - digest sha256:470a843e518147... - run 33578653745
success	1	20	1022 / 1022	2m 51s / 5m 38s	`docker run ... @sha256:8d0ebde...`	Sep 01, 01:24
run 33457896841 executed 1022 - ccache 98 hit / 6526 miss - head 63a387b4d - digest sha256:8d0ebde847ec68... - run 33457896841
success	1	20	1021 / 1021	2m 49s / 4m 41s	`docker run ... @sha256:f59ebea...`	Aug 31, 01:21
run 33346813394 executed 1021 - ccache 98 hit / 6525 miss - head 535d89aae - digest sha256:f59ebea84dd09b... - run 33346813394
success	1	20	1021 / 1021	2m 35s / 4m 31s	`docker run ... @sha256:ba5074b...`	Aug 30, 01:19
run 33285013821 executed 1021 - ccache 98 hit / 6525 miss - head 510a18121 - digest sha256:ba5074bcf68976... - run 33285013821
success	1	20	1021 / 1021	2m 48s / 4m 41s	`docker run ... @sha256:ce1f3ed...`	Aug 29, 01:02
run 33224821033 executed 1021 - ccache 98 hit / 6525 miss - head 1c959359f - digest sha256:ce1f3eda5a2473... - run 33224821033
success	1	20	1021 / 1021	3m 00s / 5m 37s	`docker run ... @sha256:48db18f...`	Aug 28, 01:02
run 33131030950 executed 1021 - ccache 98 hit / 6525 miss - head 768188590 - digest sha256:48db18f65c9f6a... - run 33131030950
success	1	20	1021 / 1021	2m 10s / 4m 25s	`docker run ... @sha256:d667cab...`	Aug 27, 00:59
run 33028068546 executed 1021 - ccache 98 hit / 6525 miss - head 8b2f4dcf9 - digest sha256:d667cab8888f68... - run 33028068546
success	1	20	1024 / 1024	2m 57s / 5m 39s	`docker run ... @sha256:05aa486...`	Aug 26, 01:00
run 32916506156 executed 1024 - ccache 98 hit / 6525 miss - head ef6806f28 - digest sha256:05aa48689db324... - run 32916506156
success	1	20	1024 / 1024	2m 45s / 4m 38s	`docker run ... @sha256:fc022d5...`	Aug 25, 00:45
run 32794193053 executed 1024 - ccache 98 hit / 6525 miss - head 6a1425d51 - digest sha256:fc022d5ea64853... - run 32794193053
success	1	20	1023 / 1023	2m 54s / 5m 44s	`docker run ... @sha256:42e5d21...`	Aug 24, 00:45
run 32677053312 executed 1023 - ccache 98 hit / 6525 miss - head 093df0bb8 - digest sha256:42e5d2102da656... - run 32677053312
success	1	20	1023 / 1023	2m 18s / 4m 50s	`docker run ... @sha256:363070a...`	Aug 23, 00:42
run 32608114793 executed 1023 - ccache 98 hit / 6525 miss - head 7c1e0060b - digest sha256:363070a8bff720... - run 32608114793
success	1	20	1023 / 1023	2m 53s / 5m 25s	`docker run ... @sha256:d3867d7...`	Aug 22, 00:42
run 32540608678 executed 1023 - ccache 98 hit / 6525 miss - head e9b4d4627 - digest sha256:d3867d7583bd47... - run 32540608678
success	1	20	1023 / 1023	2m 16s / 4m 58s	`docker run ... @sha256:22de5c6...`	Aug 21, 00:40
run 32432869993 executed 1023 - ccache 98 hit / 6525 miss - head e84734d24 - digest sha256:22de5c6581acf6... - run 32432869993
success	1	20	1023 / 1023	2m 53s / 5m 09s	`docker run ... @sha256:7b156da...`	Aug 20, 00:40
run 32317401642 executed 1023 - ccache 98 hit / 6525 miss - head 7d78382d9 - digest sha256:7b156da4210dfc... - run 32317401642
success	1	20	1023 / 1023	2m 51s / 5m 06s	`docker run ... @sha256:9168474...`	Aug 19, 00:38
run 32201245256 executed 1023 - ccache 98 hit / 6525 miss - head 7a06f7b50 - digest sha256:916847486cf093... - run 32201245256
success	1	20	1019 / 1019	2m 47s / 5m 23s	`docker run ... @sha256:fb57fa5...`	Aug 18, 00:37
run 32084420652 executed 1019 - ccache 98 hit / 6524 miss - head 25d2f6a21 - digest sha256:fb57fa5240524b... - run 32084420652
success	1	20	1019 / 1019	2m 51s / 4m 51s	`docker run ... @sha256:2324780...`	Aug 17, 00:32
run 31981792995 executed 1019 - ccache 98 hit / 6524 miss - head 066442257 - digest sha256:232478068adfc5... - run 31981792995
success	1	20	1019 / 1019	2m 48s / 5m 08s	`docker run ... @sha256:0433e64...`	Aug 16, 00:14
run 31916327298 executed 1019 - ccache 98 hit / 6524 miss - head a10840c9d - digest sha256:0433e649074944... - run 31916327298
success	1	20	1019 / 1019	2m 54s / 5m 16s	`docker run ... @sha256:aa36655...`	Aug 15, 00:13
run 31852387933 executed 1019 - ccache 98 hit / 6524 miss - head 60635bdf3 - digest sha256:aa36655d64c90e... - run 31852387933
success	1	20	1019 / 1019	2m 57s / 5m 29s	`docker run ... @sha256:3123b00...`	Aug 14, 00:12
run 31755940175 executed 1019 - ccache 165 hit / 6457 miss - head e28447700 - digest sha256:3123b00de64dc8... - run 31755940175
success	1	20	1019 / 1019	2m 57s / 5m 27s	`docker run ... @sha256:1fe67e8...`	Aug 13, 00:11
run 31652900391 executed 1019 - ccache 165 hit / 6457 miss - head 88b629658 - digest sha256:1fe67e80b215be... - run 31652900391
success	1	20	1019 / 1019	2m 47s / 5m 30s	`docker run ... @sha256:f9ddecf...`	Aug 12, 00:09
run 31548484783 executed 1019 - ccache 165 hit / 6453 miss - head 31873cc54 - digest sha256:f9ddecf05a1b9c... - run 31548484783
success	1	20	1019 / 1019	2m 48s / 5m 21s	`docker run ... @sha256:74172fc...`	Aug 11, 00:07
run 31444256867 executed 1019 - ccache 165 hit / 6453 miss - head 3fd3d45df - digest sha256:74172fcb733332... - run 31444256867
success	1	20	1019 / 1019	2m 47s / 5m 01s	`docker run ... @sha256:fa9d095...`	Aug 10, 00:10
run 31343074384 executed 1019 - ccache 166 hit / 6452 miss - head 9ae247686 - digest sha256:fa9d095aad7c01... - run 31343074384
success	1	20	1019 / 1019	2m 45s / 5m 19s	`docker run ... @sha256:d19406c...`	Aug 07, 15:52
run 31193901301 executed 1019 - ccache 166 hit / 6452 miss - head 614e5b699 - digest sha256:d19406c407f998... - run 31193901301
infra error	1	-	-	-	-	Aug 06, 16:26
run 31116994653 head 3990f4a4e - run 31116994653
success	1	20	1018 / 1018	2m 48s / 5m 24s	`docker run ... @sha256:3c2e9d2...`	Aug 05, 15:51
run 31021422106 executed 1018 - ccache 166 hit / 6452 miss - head cd0e50eea - digest sha256:3c2e9d20cda21b... - run 31021422106
success	1	20	1018 / 1018	2m 51s / 5m 26s	`docker run ... @sha256:012bfd8...`	Aug 04, 15:48
run 30925135319 executed 1018 - ccache 166 hit / 6452 miss - head 44d8319f9 - digest sha256:012bfd8955aba1... - run 30925135319
success	1	20	1017 / 1017	2m 50s / 5m 34s	`docker run ... @sha256:c350b91...`	Aug 03, 15:47
run 30828328112 executed 1017 - ccache 166 hit / 6452 miss - head 9505416d7 - digest sha256:c350b91f8f6a3a... - run 30828328112
success	1	20	1017 / 1017	2m 48s / 5m 24s	`docker run ... @sha256:b9e09ac...`	Aug 02, 15:48
run 30754773945 executed 1017 - ccache 166 hit / 6452 miss - head a0f06a938 - digest sha256:b9e09ac08f8f42... - run 30754773945
success	1	20	1017 / 1017	2m 54s / 5m 27s	`docker run ... @sha256:89a38f7...`	Aug 01, 15:45
run 30706216875 executed 1017 - ccache 166 hit / 6452 miss - head b3e9b9b93 - digest sha256:89a38f7d48537d... - run 30706216875
success	1	20	1016 / 1016	2m 16s / 4m 09s	`docker run ... @sha256:0363a8e...`	Jul 31, 15:43
run 30643458417 executed 1016 - ccache 166 hit / 6452 miss - head 6f8c3b8ce - digest sha256:0363a8e3186229... - run 30643458417
success	1	20	1016 / 1016	2m 49s / 4m 56s	`docker run ... @sha256:40ace11...`	Jul 30, 15:44
run 30557244412 executed 1016 - ccache 166 hit / 6452 miss - head 0483e13e3 - digest sha256:40ace119b595fc... - run 30557244412
success	1	20	1016 / 1016	2m 52s / 5m 20s	`docker run ... @sha256:8bd4b8c...`	Jul 29, 15:43
run 30466330255 executed 1016 - ccache 166 hit / 6452 miss - head a6e448d06 - digest sha256:8bd4b8ca868530... - run 30466330255
success	1	20	1014 / 1014	2m 51s / 5m 09s	`docker run ... @sha256:1829dac...`	Jul 28, 15:43
run 30373782886 executed 1014 - ccache 166 hit / 6452 miss - head 0aefc30ef - digest sha256:1829dac5fd16a8... - run 30373782886
success	1	20	1013 / 1013	2m 57s / 5m 19s	`docker run ... @sha256:561e1ba...`	Jul 27, 00:36
run 30227417171 executed 1013 - ccache 166 hit / 6452 miss - head f1761f997 - digest sha256:561e1ba1c44086... - run 30227417171