Non-Active links being referred in our source code
Hi,
There are few links present in our source files for which the web links are no more active.
Details for the same is given below:
Sl No
Link
Referred File
1
http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf <http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf>
generic-acc.h
2
http://h21007.www2.hp.com/portal/download/files/unprot/itanium/spinlocks.pdf <http://h21007.www2.hp.com/portal/download/files/unprot/itanium/spinlocks.pdf>
generic-acc.h
3
http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt <http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt>
win32_port.h
4
http://www.microsoft.com/msj/0197/exception/exception.aspx <http://www.microsoft.com/msj/0197/exception/exception.aspx>
win32_port.h
5
http://www.nologs.com/ntstatus.html <http://www.nologs.com/ntstatus.html>
win32_port.h
6
http://www.ross.net/crc/ <http://www.ross.net/crc/>
pg_crc.h
7
http://www.ross.net/crc/download/crc_v3.txt <http://www.ross.net/crc/download/crc_v3.txt>
pg_crc.h
8
http://www.codeproject.com/string/dmetaphone1.asp <http://www.codeproject.com/string/dmetaphone1.asp>
dmetaphone.c
9
http://www.postgresql.org/2009/explain <http://www.postgresql.org/2009/explain>
explain.c
10
http://www.merriampark.com/ld.htm <http://www.merriampark.com/ld.htm>
levenshtein.c
11
http://www.cs.auckland.ac.nz/software/AlgAnim/niemann/s_man.htm <http://www.cs.auckland.ac.nz/software/AlgAnim/niemann/s_man.htm>
rbtree.c
I could not find the equivalent links for the same.
Should we update the links for the same?
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com <http://www.enterprisedb.com/>
On Sun, Oct 06, 2019 at 09:06:44AM +0530, vignesh C wrote:
I could not find the equivalent links for the same.
Should we update the links for the same?
If it could be possible to find equivalent links which could update
to, it would be nice.
--
Michael
On Sun, Oct 6, 2019 at 9:41 AM Michael Paquier <michael@paquier.xyz> wrote:
On Sun, Oct 06, 2019 at 09:06:44AM +0530, vignesh C wrote:
I could not find the equivalent links for the same.
Should we update the links for the same?If it could be possible to find equivalent links which could update
to, it would be nice.
About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.
Please find attached a patch with the proposed alternatives.
Regards,
Juan José Santamaría Flecha
Attachments:
0001-Non-Active-links-in-win32_port.patchapplication/octet-stream; name=0001-Non-Active-links-in-win32_port.patchDownload+6-16
On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:
About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.Please find attached a patch with the proposed alternatives.
Thanks Juan for the patch. I have checked your suggestions and it
looks good to me, so committed. Good idea to tell about
WIN32_NO_STATUS. I have noticed one typo on the way.
--
Michael
On Tue, Oct 8, 2019 at 10:35 AM Michael Paquier <michael@paquier.xyz> wrote:
On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:
About the broken links in win32_port.h, they are all referring to
ntstatus. As for first case that shows the code groups, there is an up
to date alternative. There is also an alternative for second case that
points to their codes and descriptions. On the other hand, the last
case is quoting a document that is no longer available, I would
suggest to rephrase the comment, thus eliminating the quote.Please find attached a patch with the proposed alternatives.
Thanks Juan for the patch. I have checked your suggestions and it
looks good to me, so committed. Good idea to tell about
WIN32_NO_STATUS. I have noticed one typo on the way.
About pg_crc.h, I have made the changes with the correct links.
The patch for the same is attached.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com