Fix typos in ExecChooseHashTableSize()

Started by Tender Wang8 months ago3 messageshackers
Jump to latest
#1Tender Wang
tndrwang@gmail.com

Hi,

While stepping into the ExecChooseHashTableSize(),
I found two typos in the comments
One is as follows:
/* Check that buckets wont't overflow MaxAllocSize */
if (nbuckets > (MaxAllocSize / sizeof(HashJoinTuple) / 2))
break;

The other one is :

/*
* Check that space_allowed won't overlow SIZE_MAX.
*
* We don't use hash_table_bytes here, because it does not include the
* skew buckets. And we want to limit the overall memory limit.
*/
if ((*space_allowed) > (SIZE_MAX / 2))
break;

In the first comment, "wont't" should be "won't".
In the second comment, "overlow" should be "overflow".
The attached patch fixes these typos.
--
Thanks,
Tender Wang

Attachments:

0001-Fix-typos-in-the-comment.patchapplication/octet-stream; name=0001-Fix-typos-in-the-comment.patchDownload+2-3
#2Richard Guo
guofenglinux@gmail.com
In reply to: Tender Wang (#1)
Re: Fix typos in ExecChooseHashTableSize()

On Tue, Nov 18, 2025 at 6:30 PM Tender Wang <tndrwang@gmail.com> wrote:

In the first comment, "wont't" should be "won't".
In the second comment, "overlow" should be "overflow".

The first one was fixed by Álvaro in another commit. I've just pushed
a fix for the second one.

- Richard

#3Tender Wang
tndrwang@gmail.com
In reply to: Richard Guo (#2)
Re: Fix typos in ExecChooseHashTableSize()

Richard Guo <guofenglinux@gmail.com> 于2025年11月19日周三 10:18写道:

On Tue, Nov 18, 2025 at 6:30 PM Tender Wang <tndrwang@gmail.com> wrote:

In the first comment, "wont't" should be "won't".
In the second comment, "overlow" should be "overflow".

The first one was fixed by Álvaro in another commit. I've just pushed
a fix for the second one.

- Richard

Thanks for pushing.
--
Thanks,
Tender Wang