[PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

On Sep 21, 2025, at 22:48, Steve Lau <stevelauc@outlook.com> wrote:

Hi hackers!

Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:

join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the

Regards,
steve

<v1-0001-Correct-RangeTblEntry.join_using_alias-comment-to-re.patch>

“alias” is the second field of structure RangeTblEntry, so it should be above “join_using_alias”.

The change looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

On Sun, Sep 21, 2025 at 11:54 PM Steve Lau <stevelauc@outlook.com> wrote:

Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:

join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the

Nice catch. Will push the patch.

- Richard

On Mon, 22 Sept 2025 at 11:56, Richard Guo <guofenglinux@gmail.com> wrote:

On Sun, Sep 21, 2025 at 11:54 PM Steve Lau <stevelauc@outlook.com> wrote:

Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:

join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the

Nice catch. Will push the patch.

I was just working on a script to find others and it highlighted a
bunch more. Do you still want to do this one, or should I take them
all in one fell swoop?

David

On Mon, 22 Sept 2025 at 12:49, David Rowley <dgrowleyml@gmail.com> wrote:

On Mon, 22 Sept 2025 at 11:56, Richard Guo <guofenglinux@gmail.com> wrote:

Nice catch. Will push the patch.

I was just working on a script to find others and it highlighted a
bunch more. Do you still want to do this one, or should I take them
all in one fell swoop?

Please disregard the above. Wrong thread.

David