pgsql: Build ICU support by default.
Build ICU support by default.
Discussion: /messages/by-id/82c4c816-06f6-d3e3-ba02-fca4a5cef065@enterprisedb.com
Reviewed-by: Peter Eisentraut
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fcb21b3acdcb9a60313325618fd7080aa36f1626
Modified Files
--------------
.cirrus.yml | 1 +
configure | 36 +++++++-------------
configure.ac | 8 +++--
doc/src/sgml/installation.sgml | 76 +++++++++++++++++++++++-------------------
4 files changed, 61 insertions(+), 60 deletions(-)
On Tue, Apr 18, 2023 at 08:36:45PM +0000, Jeff Davis wrote:
Build ICU support by default.
As guaibasaurus is telling, this broke the generation of the
distribution tarball:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A03
The problem is easy to reproduce: just run "make dist" from the top of
the tree. The fix is a bit more tricky, straight-forward once you
know that ./INSTALL is generated from the contents of
installation.sgml (learnt that the hard way), and is similar to
45aa88f where you should add a few extra rules to
standalone-profile.xsl to replace the links by some text. I guess
that you could just replace both references with "the documentation"
in this case, as the terms are specified in the paragraphs generated
in the ./INSTALL, like the attached.
Do you mind if I apply the attached to fix the issue?
--
Michael
Attachments:
collation-fix-make-dist.patchtext/x-diff; charset=us-asciiDownload+8-0
On Wed, 2023-04-19 at 09:46 +0900, Michael Paquier wrote:
As guaibasaurus is telling, this broke the generation of the
distribution tarball:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A03The problem is easy to reproduce: just run "make dist" from the top
of
the tree. The fix is a bit more tricky, straight-forward once you
know that ./INSTALL is generated from the contents of
installation.sgml (learnt that the hard way), and is similar to
45aa88f where you should add a few extra rules to
standalone-profile.xsl to replace the links by some text. I guess
that you could just replace both references with "the documentation"
in this case, as the terms are specified in the paragraphs generated
in the ./INSTALL, like the attached.
Ah, thank you.
Do you mind if I apply the attached to fix the issue?
Please go ahead.
Regards,
Jeff Davis