[PATCH] Miscellaneous little fixes
Hi,
I noticed several little defects in the code:
1. There are several typos in the comments: "fist" instead of "first"
2. The comment in network.c claims that IPv6 has 64 bits (in fact 128)
3. oid_hash macro is not used for a long time and can be removed.
Here is the patch.
--
Best regards,
Aleksander Alekseev
Attachments:
v1-0001-Miscellaneous-little-fixes.patchtext/x-patch; charset=US-ASCII; name=v1-0001-Miscellaneous-little-fixes.patchDownload+4-10
On Tue, Apr 14, 2026 at 06:20:41PM +0300, Aleksander Alekseev wrote:
3. oid_hash macro is not used for a long time and can be removed.
There is no cost in keeping it, and removing it could break some
extension code out there..
Picked up the rest in a staging branch.
--
Michael
On Wed, 15 Apr 2026 at 09:29, Michael Paquier <michael@paquier.xyz> wrote:
Picked up the rest in a staging branch.
One more in [1]/messages/by-id/CA+3i_M8QOnjeG1GN+rqncnF52-Uo5fr+b=FxzqWAH41BP3oFpg@mail.gmail.com and one I noticed a while ago attached, if you feel
like including those too.
David
[1]: /messages/by-id/CA+3i_M8QOnjeG1GN+rqncnF52-Uo5fr+b=FxzqWAH41BP3oFpg@mail.gmail.com
Attachments:
typo_fix.patchapplication/octet-stream; name=typo_fix.patchDownload+2-0
On Wed, Apr 15, 2026 at 10:41:28AM +1200, David Rowley wrote:
One more in [1] and one I noticed a while ago attached, if you feel
like including those too.
Thanks. I have grabbed these two.
--
Michael
On Apr 15, 2026, at 08:47, Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Apr 15, 2026 at 10:41:28AM +1200, David Rowley wrote:
One more in [1] and one I noticed a while ago attached, if you feel
like including those too.Thanks. I have grabbed these two.
--
Michael
Maybe add this one, see the attached diff file. This is an oversight of 82467f627bd478569de04f4a3f1993098e80c812. I ever notified the author about this typo, but I guess he missed my message.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Attachments:
fix_typo_heapam_visibility_c.diffapplication/octet-stream; name=fix_typo_heapam_visibility_c.diff; x-unix-mode=0644Download+1-1
On Wed, Apr 15, 2026 at 08:56:02AM +0800, Chao Li wrote:
Maybe add this one, see the attached diff file. This is an oversight
of 82467f627bd478569de04f4a3f1993098e80c812. I ever notified the
author about this typo, but I guess he missed my message.
That sounds about right.
--
Michael
Hi Michael,
Thanks for picking this up.
There is no cost in keeping it, and removing it could break some
extension code out there..
Of course it's up to you to decide, but I wanted to point out the
comment written in 2014 says:
/* Remove me eventually */
... soooooo. IMO 12 years is quite enough for eventually and for a
line of code that is not covered by any tests :)
--
Best regards,
Aleksander Alekseev