pgsql-server/src/test/regress resultmap expect ...

Started by Tom Laneover 23 years ago2 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/12/13 15:35:57

Modified files:
src/test/regress: resultmap
Added files:
src/test/regress/expected: geometry_1.out
Removed files:
src/test/regress/expected: geometry-positive-zeros.out

Log message:
Admit defeat on the prospect of keeping straight exactly which platforms
produce which output in the geometry test, even with the problem narrowed
down to only whether they print minus zero or not. Instead, use
pg_regress' locale-variant mechanism to automatically consider the test
to pass if it matches either supplied comparison file. geometry_1.out
replaces the former geometry-positive-zeros.out.

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: [COMMITTERS] pgsql-server/src/test/regress resultmap expect ...

Tom Lane wrote:

CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/12/13 15:35:57

Modified files:
src/test/regress: resultmap
Added files:
src/test/regress/expected: geometry_1.out
Removed files:
src/test/regress/expected: geometry-positive-zeros.out

Log message:
Admit defeat on the prospect of keeping straight exactly which platforms
produce which output in the geometry test, even with the problem narrowed
down to only whether they print minus zero or not. Instead, use
pg_regress' locale-variant mechanism to automatically consider the test
to pass if it matches either supplied comparison file. geometry_1.out
replaces the former geometry-positive-zeros.out.

One issue is how are we going to know when a results file _isn't_ needed
anymore, because we will not be matching regression files against
platforms anymore? Do we need a comment somewhere in the file?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073