AclId is defined in the wrong place

Started by Tom Laneover 23 years ago3 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

I'd like to move the typedef for AclId out of miscadmin.h, where it was
originally placed, and into postgres.h or c.h where most other fundamental
typedefs appear. As is, we've got a problem with miscadmin.h having
to be included into many header files where it doesn't belong, and that
problem is going to get worse.

Any objection?

regards, tom lane

#2Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#1)
Re: AclId is defined in the wrong place

Tom Lane wrote:

I'd like to move the typedef for AclId out of miscadmin.h, where it was
originally placed, and into postgres.h or c.h where most other fundamental
typedefs appear. As is, we've got a problem with miscadmin.h having
to be included into many header files where it doesn't belong, and that
problem is going to get worse.

Any objection?

No problem, go ahead. I put it there only because I needed it for some
of the prototypes, and I didn't want to be so bold as to move it even
farther up into the include system, but if you like it there, that is
fine. I did quite a bit of wholesale AclId mapping so you may want to
look at the patch to see where I had to add miscadmin.h.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#2)
Re: AclId is defined in the wrong place

Bruce Momjian <pgman@candle.pha.pa.us> writes:

No problem, go ahead. I put it there only because I needed it for some
of the prototypes, and I didn't want to be so bold as to move it even
farther up into the include system,

Properly so --- but if the consequence is to have to include miscadmin.h
into other header files, then really you're polluting namespace more
rather than less, because of the other baggage carried along by
miscadmin.h.

regards, tom lane