Re: src/port/fseeko.c revision 1.9 broken on NetBSD

Started by Bruce Momjianover 23 years ago1 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

The change was made because a BSD/OS developer said flockfile was POSIX,
and pointed to something that suggested NetBSD supports it. I will back
out the change. We really don't need fseeko/ftello to be thread safe
anyway.

---------------------------------------------------------------------------

Giles Lean wrote:

Hi Bruce,

The change in revision 1.9 of src/port/fseeko.c to include <pthread.h>
and use flockfile() and funlockfile() on NetBSD causes the file not to
compile:

1. there is no <pthread.h> on any NetBSD release (yet)

2. flockfile() and funlockfile() appear in <stdio.h> commented
out by #if 0 ... #endif and are not implemented.

I'm not sure if I led you astray on the presence of these functions
on NetBSD. My appologies if I did; a grep of /usr/include/*.h is
misleading. Whatever POSIX extension they're part of is not yet
implemented on NetBSD.

The fix is to revert to revision 1.8. I could send you a diff, but
it's pretty boring. :-)

Regards,

Giles

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073