more custom C function fun

Harvey, Allan AC wrote:

Try if(thestr[20] == 0x29)
might reveal something in the parsing if it works.

No effect.

- Dan

On Mon, May 05, 2008 at 11:43:40PM -0600, Dan Heron Myers wrote:

I have a custom C function that takes two text*s and returns a text*.

text* calling_party = PG_GETARG_TEXT_P(0);

char* thestr = VARDATA(calling_party);
if(thestr[20] == ')')
{
PG_RETURN_TEXT_P(calling_party);
}

You do realise that VARDATA does not return a null terminated string?
Try using something like text_to_cstring or using elog(NOTICE) to
display what's actually being compared.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/

Martijn van Oosterhout wrote:

You do realise that VARDATA does not return a null terminated string?

I did not realize that... but it led me in the right direction.

Try using something like text_to_cstring or using elog(NOTICE) to
display what's actually being compared.

I've outputted some things with elog (which is the other thing I needed
to figure this out).

Using DatumToCString(mytextvariable), I get single-character-length
strings that do not match the data actually in the fields.

Using VARDATA(mytextvariable) as the char*, I get things like this (name
obscured) (using strlen to get the string's length):

string: "Hillary Clinton(6611)", length 21
string: "95555551234nton(6611)", length 21

Of course, then I realized that strlen isn't the right tool for the job;
I need: int len = VARSIZE(mytextvariable) - VARHDRSZ;

Using that with the VARDATA as my char*, I get this:

string: "Hillary Clinton(6611)" - length: 21
string: "95555551234" - length: 11

Which is what I need. Perhaps we could get some documentation about how
to use this stuff? I was unable to find any on the Postgres site, if
there is any.

Thanks for your help guys :)

- Dan

On Tue, May 06, 2008 at 09:39:50AM -0600, Dan Heron Myers wrote:

Using DatumToCString(mytextvariable), I get single-character-length
strings that do not match the data actually in the fields.

Correct, because it's not a cstring. Pretending it is one gives you
garbage.

Using VARDATA(mytextvariable) as the char*, I get things like this (name
obscured) (using strlen to get the string's length):

Not null terminated.

Which is what I need. Perhaps we could get some documentation about how
to use this stuff? I was unable to find any on the Postgres site, if
there is any.

Well, here's an example of how you should do it:

http://www.postgresql.org/docs/8.2/interactive/spi-examples.html

Not the most obvious place. The best place is the source,
utils/adt/text contains lots of functions on text variables, so you can
see how they work.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/