threads.c
I have a few problems with the file threads.c:
1. It doesn't contain any threads, so the name is slightly inappropriate.
2. It's not a porting module (since pqStrerror, etc. are not system
functions), so it doesn't belong into src/port.
3. It's only used by libpq, so why not put it into the libpq directory?
Comments?
--
Peter Eisentraut peter_e@gmx.net
It was in libpq in my original patch, not port.
L.
Peter Eisentraut writes:
Show quoted text
I have a few problems with the file threads.c:
1. It doesn't contain any threads, so the name is slightly inappropriate.
2. It's not a porting module (since pqStrerror, etc. are not system
functions), so it doesn't belong into src/port.3. It's only used by libpq, so why not put it into the libpq directory?
Comments?
Peter Eisentraut wrote:
I have a few problems with the file threads.c:
1. It doesn't contain any threads, so the name is slightly inappropriate.
2. It's not a porting module (since pqStrerror, etc. are not system
functions), so it doesn't belong into src/port.3. It's only used by libpq, so why not put it into the libpq directory?
Tom suggested I move it to port because other interfaces might need it,
and in fact if they do, they will need to call those functions. I can
rename it to 'threaded', or move it back to libpq.
Votes?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073