Aggregate function with subquery in 8.3 and 8.4.

Started by Sheng Y. Chengover 16 years ago3 messagesgeneral
Jump to latest
#1Sheng Y. Cheng
scheng@adconion.com

PostgreSQL version: 8.4.0 / 8.3.1
Operating system: Red Hat 4.1.1-52
Description: Aggregate function with subquery in 8.3 and 8.4.
Details:

Here are some facts and questions about the aggregate function with
subquery
in 8.3 and 8.4.

================= Question 1. ==================
I though the following query would give me the same results in 8.4.0 and
8.3.1.

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN;
SELECT version();
CREATE TEMPORARY TABLE t1 (f1 text ) on commit drop ;
CREATE TEMPORARY TABLE t2 (f1 text ) on commit drop ;
INSERT INTO t1 (f1) VALUES ('aaa');
INSERT INTO t1 (f1) VALUES ('bbb');
INSERT INTO t1 (f1) VALUES ('ccc');
INSERT INTO t2 (f1) VALUES ('bbb');

SELECT t1.f1, COUNT(ts.*) FROM
t1
LEFT JOIN
(SELECT
CASE WHEN f1 = '111'
THEN '111'
ELSE
f1
END
FROM t2) AS ts
ON
t1.f1 = ts.f1
GROUP BY
t1.f1;

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

However, In 8.3.1 I got the following.

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN
version

----------------------------------------------------------------------------

-------------------------------
PostgreSQL 8.3.1 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC)
4.1.1 20070105 (Red Hat 4.1.1-52)
(1 row)

CREATE TABLE
CREATE TABLE
INSERT 0 1
INSERT 0 1
INSERT 0 1
INSERT 0 1
f1 | count
-----+-------
aaa | 0
bbb | 1
ccc | 0
(3 rows)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Whereas, in 8.4.0 I got the following.

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN
version

----------------------------------------------------------------------------

---------------------------------------
PostgreSQL 8.4.0 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC)
4.1.1 20070105 (Red Hat 4.1.1-52), 64-bit
(1 row)

CREATE TABLE
CREATE TABLE
INSERT 0 1
INSERT 0 1
INSERT 0 1
INSERT 0 1
f1 | count
-----+-------
aaa | 1
bbb | 1
ccc | 1
(3 rows)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The Session 4.2.7. Aggregate Expressions in 8.3 document at
http://www.postgresql.org/docs/8.3/static/sql-expressions.html states "The
last form invokes the aggregate once for each input row regardless of null
or non-null values." I am wondering if the result I saw from 8.4.0 is a bug
fix for 8.3.1?

================= Question 2. ==================
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN;
SELECT version();
CREATE TEMPORARY TABLE t1 (f1 text ) on commit drop ;
CREATE TEMPORARY TABLE t2 (f1 text ) on commit drop ;
INSERT INTO t1 (f1) VALUES ('aaa');
INSERT INTO t1 (f1) VALUES ('bbb');
INSERT INTO t1 (f1) VALUES ('ccc');
INSERT INTO t2 (f1) VALUES ('bbb');

SELECT t1.f1, COUNT(ts.*) FROM
t1
LEFT JOIN
(SELECT
f1
FROM t2) AS ts
ON
t1.f1 = ts.f1
GROUP BY
t1.f1;

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I though the result of the above query would be the following.

f1 | count
-----+-------
aaa | 0
bbb | 1
ccc | 0

however, I got the following in both 8.4.0 and 8.3.1.

Result from 8.3.1.
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN
version

----------------------------------------------------------------------------

-------------------------------
PostgreSQL 8.3.1 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC)
4.1.1 20070105 (Red Hat 4.1.1-52)
(1 row)

CREATE TABLE
CREATE TABLE
INSERT 0 1
INSERT 0 1
INSERT 0 1
INSERT 0 1
f1 | count
-----+-------
aaa | 1
bbb | 1
ccc | 1
(3 rows)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Result from 8.4.0.

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv

BEGIN
version

----------------------------------------------------------------------------

---------------------------------------
PostgreSQL 8.4.0 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC)
4.1.1 20070105 (Red Hat 4.1.1-52), 64-bit
(1 row)

CREATE TABLE
CREATE TABLE
INSERT 0 1
INSERT 0 1
INSERT 0 1
INSERT 0 1
f1 | count
-----+-------
aaa | 1
bbb | 1
ccc | 1
(3 rows)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is this how Postgres works for aggregate function?

Thank you,

Sheng

#2Sam Mason
sam@samason.me.uk
In reply to: Sheng Y. Cheng (#1)
Re: Aggregate function with subquery in 8.3 and 8.4.

On Mon, Aug 31, 2009 at 04:02:43PM -0700, Sheng Cheng wrote:

I though the following query would give me the same results in 8.4.0 and
8.3.1.

It should give the same results! This looks like a bug in 8.4 to me, in
an attempt to optimize things it's pulling the CASE out from inside the
inner select and this is changing the semantics of the query. Doing an
EXPLAIN in 8.4 gives the following:

GroupAggregate (cost=181.86..387.73 rows=200 width=64)
-> Merge Left Join (cost=181.86..341.83 rows=8580 width=64)
Merge Cond: (t1.f1 = (CASE WHEN (t2.f1 = '111'::text) THEN '111'::text
ELSE t2.f1 END))
-> Sort (cost=90.93..94.20 rows=1310 width=32)
Sort Key: t1.f1
-> Seq Scan on t1 (cost=0.00..23.10 rows=1310 width=32)
-> Sort (cost=90.93..94.20 rows=1310 width=64)
Sort Key: (CASE WHEN (t2.f1 = '111'::text) THEN '111'::text ELSE
t2.f1 END)
-> Seq Scan on t2 (cost=0.00..23.10 rows=1310 width=64)

While in 8.3 I get:

GroupAggregate (cost=198.23..378.88 rows=200 width=64)
-> Merge Left Join (cost=198.23..333.48 rows=8580 width=64)
Merge Cond: (t1.f1 = ts.f1)
-> Sort (cost=90.93..94.20 rows=1310 width=32)
Sort Key: t1.f1
-> Seq Scan on t1 (cost=0.00..23.10 rows=1310 width=32)
-> Sort (cost=107.30..110.58 rows=1310 width=64)
Sort Key: ts.f1
-> Subquery Scan ts (cost=0.00..39.48 rows=1310 width=64)
-> Seq Scan on t2 (cost=0.00..26.38 rows=1310 width=32)

Notice that the "Merge Cond" is working on the CASE expression in 8.4.
This is too late and is breaking things.

--
Sam http://samason.me.uk/

#3Sam Mason
sam@samason.me.uk
In reply to: Sam Mason (#2)
Re: Aggregate function with subquery in 8.3 and 8.4.

On Tue, Sep 01, 2009 at 10:05:44AM +0100, Sam Mason wrote:

On Mon, Aug 31, 2009 at 04:02:43PM -0700, Sheng Cheng wrote:

I though the following query would give me the same results in 8.4.0 and
8.3.1.

It should give the same results! This looks like a bug in 8.4 to me

I've just noticed this was (invisibly to me) cross-posted to -bugs as
well. Probably best to reply there.

--
Sam http://samason.me.uk/