CREATE USER bug

Started by Joshua D. Drakeover 22 years ago4 messages
#1Joshua D. Drake
jd@commandprompt.com

Hello,

It seems to me that the below should not be able to happen.

postgres=# create user with encrypted password '98wq7912a';
CREATE USER
postgres=# create user with encrypted password '98wq7912a';
ERROR: CREATE USER: user name "with" already exists

Sincerley,

Joshua D. Drake

-- 
Command Prompt, Inc., home of Mammoth PostgreSQL - S/ODBC and S/JDBC
Postgresql support, programming shared hosting and dedicated hosting.
+1-503-222-2783 - jd@commandprompt.com - http://www.commandprompt.com
Editor-N-Chief - PostgreSQl.Org - http://www.postgresql.org
#2Neil Conway
neilc@samurai.com
In reply to: Joshua D. Drake (#1)
Re: CREATE USER bug

On Mon, 2003-10-06 at 16:21, Joshua D. Drake wrote:

postgres=# create user with encrypted password '98wq7912a';
CREATE USER
postgres=# create user with encrypted password '98wq7912a';
ERROR: CREATE USER: user name "with" already exists

So, what are we doing about this? If we're considering it a bug, one way
to fix it is to move WITH from unreserved_keywords to reserved_keywords.
Any other suggestions?

-Neil

#3Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Neil Conway (#2)
Re: CREATE USER bug

Neil Conway wrote:

On Mon, 2003-10-06 at 16:21, Joshua D. Drake wrote:

postgres=# create user with encrypted password '98wq7912a';
CREATE USER
postgres=# create user with encrypted password '98wq7912a';
ERROR: CREATE USER: user name "with" already exists

So, what are we doing about this? If we're considering it a bug, one way
to fix it is to move WITH from unreserved_keywords to reserved_keywords.
Any other suggestions?

I think the code is fine as it is now, seeing how WITH is optional:

CREATE USER username [ [ WITH ] option [ ... ] ]

I don't see a huge problem with allowing "with" as a user name. Of
course, we could require them to write:

CREATE USER with WITH ...

but then WITH isn't optional anymore, at least for a user named 'with'.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Neil Conway (#2)
Re: CREATE USER bug

Neil Conway <neilc@samurai.com> writes:

On Mon, 2003-10-06 at 16:21, Joshua D. Drake wrote:

postgres=# create user with encrypted password '98wq7912a';
CREATE USER
postgres=# create user with encrypted password '98wq7912a';
ERROR: CREATE USER: user name "with" already exists

So, what are we doing about this? If we're considering it a bug, one way
to fix it is to move WITH from unreserved_keywords to reserved_keywords.
Any other suggestions?

It's not a bug.

regards, tom lane