Documentation issue

Started by salah jubehalmost 15 years ago6 messagesgeneral

s_jubeh@yahoo.com

almost 15 years ago

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
include to the utils/geo_decls.h which leads to compilation errors. i.e #include
"utils/geo_decls.h"
needs to be added to the code.

Kind regards

Bruce Momjian

bruce@momjian.us

almost 15 years ago

In reply to: salah jubeh (#1)

Re: Documentation issue

salah jubeh wrote:

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
include to the utils/geo_decls.h which leads to compilation errors. i.e #include
"utils/geo_decls.h"
needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

salah jubeh

s_jubeh@yahoo.com

almost 15 years ago

In reply to: Bruce Momjian (#2)

Re: Documentation issue

#include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32 arg
= PG_GETARG_INT32(0);

....

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 10:58:19 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
include to the utils/geo_decls.h which leads to compilation errors. i.e
#include

"utils/geo_decls.h"
needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

Bruce Momjian

bruce@momjian.us

almost 15 years ago

In reply to: salah jubeh (#3)

Re: Documentation issue

salah jubeh wrote:

#include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32 arg
= PG_GETARG_INT32(0);

Great, this was fixed in Postgres 9.0. You can see it here:

http://www.postgresql.org/docs/9.0/static/xfunc-c.html

#include "postgres.h"
#include <string.h>
#include "utils/geo_decls.h"

#ifdef PG_MODULE_MAGIC
PG_MODULE_MAGIC;
#endif

/* by value */

int
add_one(int arg)

---------------------------------------------------------------------------

....

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 10:58:19 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing
include to the utils/geo_decls.h which leads to compilation errors. i.e
#include

"utils/geo_decls.h"
needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

salah jubeh

s_jubeh@yahoo.com

almost 15 years ago

In reply to: Bruce Momjian (#4)

Re: Documentation issue

Hello Bruce,

Indeed; However, it would be nice to update also the documentation in 8.4 it
will not take a lot of effort -:)

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 11:09:37 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

#include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32
arg

= PG_GETARG_INT32(0);

Great, this was fixed in Postgres 9.0. You can see it here:

http://www.postgresql.org/docs/9.0/static/xfunc-c.html

#include "postgres.h"
#include <string.h>
#include "utils/geo_decls.h"

#ifdef PG_MODULE_MAGIC
PG_MODULE_MAGIC;
#endif

/* by value */

int
add_one(int arg)

---------------------------------------------------------------------------

....

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 10:58:19 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing

include to the utils/geo_decls.h which leads to compilation errors. i.e
#include

"utils/geo_decls.h"
needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

Bruce Momjian

bruce@momjian.us

almost 15 years ago

In reply to: salah jubeh (#5)

Re: Documentation issue

salah jubeh wrote:

Hello Bruce,

Indeed; However, it would be nice to update also the documentation in 8.4 it
will not take a lot of effort -:)

Uh, we don't normally backpatch such things. Sorry.

---------------------------------------------------------------------------

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 11:09:37 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

#include "postgres.h" #include <string.h> #include "fmgr.h" /* by value */
PG_FUNCTION_INFO_V1(add_one); Datum add_one(PG_FUNCTION_ARGS) { int32
arg

= PG_GETARG_INT32(0);

Great, this was fixed in Postgres 9.0. You can see it here:

http://www.postgresql.org/docs/9.0/static/xfunc-c.html

#include "postgres.h"
#include <string.h>
#include "utils/geo_decls.h"

#ifdef PG_MODULE_MAGIC
PG_MODULE_MAGIC;
#endif

/* by value */

int
add_one(int arg)

---------------------------------------------------------------------------

....

Best Regard

Eng. Salah Al Jubeh

PalestinePolytechnic University
College of Applied Science
Computer Science
P.O. Box 198

Mobile:++97259369122
Tel:++97222254680

________________________________
From: Bruce Momjian <bruce@momjian.us>
To: salah jubeh <s_jubeh@yahoo.com>
Cc: pgsql <pgsql-general@postgresql.org>
Sent: Mon, July 18, 2011 10:58:19 PM
Subject: Re: [GENERAL] Documentation issue

salah jubeh wrote:

Hello,

In http://www.postgresql.org/docs/8.4/static/xfunc-c.html, there is a missing

include to the utils/geo_decls.h which leads to compilation errors. i.e
#include

"utils/geo_decls.h"
needs to be added to the code.

Uh, which function sample is missing it?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +