[PATCH v1] Fix typos in pg_bsd_indent: "dont" -> "don't" in comments Anexo: o arquivo
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t121655psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 02:50 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t121655_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t121655_1 && git checkout t121655_1Patchset v1 (message #1) is on t121655_1
Hi hackers,
Attached is a patch that fixes ten instances of missing apostrophe in contractions ("dont" -> "don't") in pg_bsd_indent source code comments.
I'm aware pg_bsd_indent is derived from FreeBSD's indent tool.
These are minor comment-only changes that don't affect behavior.
If preferred, I can submit these upstream to FreeBSD as well.
Affected files:
- src/tools/pg_bsd_indent/indent.c (7 instances)
- src/tools/pg_bsd_indent/io.c (1 instance)
- src/tools/pg_bsd_indent/pr_comment.c (2 instances)
The patch applies cleanly against current HEAD (dd5716f3c74).
Best regards,
Thiago Caserta <https://aka.ms/GetOutlookForMac>
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.
Grabbed this set as well.
--
Michael
On 2026-Mar-27, Michael Paquier wrote:
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Learn about compilers. Then everything looks like either a compiler or
a database, and now you have two problems but one of them is fun."
https://twitter.com/thingskatedid/status/1456027786158776329
Hi,
On 2026-03-27 00:21:22 +0100, Álvaro Herrera wrote:
On 2026-Mar-27, Michael Paquier wrote:
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.
FWIW, I think this a pointless kind of change. Nobody is going to be confused
by the current spelling.
Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.
Greetings,
Andres
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.
Yes, I think that is true.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
On Thu, Mar 26, 2026 at 08:17:51PM -0400, Bruce Momjian wrote:
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.Yes, I think that is true.
Updates are unlikely, IMO, but who knows. FWIW, I don't mind fixing
these. At least somebody has spent some time sending a patch for
them.
--
Michael
On Fri, Mar 27, 2026 at 12:19:37PM +0900, Michael Paquier wrote:
On Thu, Mar 26, 2026 at 08:17:51PM -0400, Bruce Momjian wrote:
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.Yes, I think that is true.
Updates are unlikely, IMO, but who knows. FWIW, I don't mind fixing
these. At least somebody has spent some time sending a patch for
them.
Agreed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.