[PATCH v1] Fix typos in pg_bsd_indent: "dont" -> "don't" in comments Anexo: o arquivo
Hi hackers,
Attached is a patch that fixes ten instances of missing apostrophe in contractions ("dont" -> "don't") in pg_bsd_indent source code comments.
I'm aware pg_bsd_indent is derived from FreeBSD's indent tool.
These are minor comment-only changes that don't affect behavior.
If preferred, I can submit these upstream to FreeBSD as well.
Affected files:
- src/tools/pg_bsd_indent/indent.c (7 instances)
- src/tools/pg_bsd_indent/io.c (1 instance)
- src/tools/pg_bsd_indent/pr_comment.c (2 instances)
The patch applies cleanly against current HEAD (dd5716f3c74).
Best regards,
Thiago Caserta <https://aka.ms/GetOutlookForMac>
Attachments:
v1-0001-Fix-typos-in-pg_bsd_indent-dont-don-t-in-comments.patchapplication/octet-stream; name=v1-0001-Fix-typos-in-pg_bsd_indent-dont-don-t-in-comments.patchDownload+10-11
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.
Grabbed this set as well.
--
Michael
On 2026-Mar-27, Michael Paquier wrote:
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Learn about compilers. Then everything looks like either a compiler or
a database, and now you have two problems but one of them is fun."
https://twitter.com/thingskatedid/status/1456027786158776329
Hi,
On 2026-03-27 00:21:22 +0100, Álvaro Herrera wrote:
On 2026-Mar-27, Michael Paquier wrote:
On Tue, Mar 24, 2026 at 07:59:51PM +0000, Thiago Caserta wrote:
Attached is a patch that fixes ten instances of missing apostrophe
in contractions ("dont" -> "don't") in pg_bsd_indent source code
comments.
FWIW, I think this a pointless kind of change. Nobody is going to be confused
by the current spelling.
Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.
Greetings,
Andres
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
Grabbed this set as well.
I think waiting for it to be taken by FreeBSD wouldn't be a bad thing.
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.
Yes, I think that is true.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
On Thu, Mar 26, 2026 at 08:17:51PM -0400, Bruce Momjian wrote:
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.Yes, I think that is true.
Updates are unlikely, IMO, but who knows. FWIW, I don't mind fixing
these. At least somebody has spent some time sending a patch for
them.
--
Michael
On Fri, Mar 27, 2026 at 12:19:37PM +0900, Michael Paquier wrote:
On Thu, Mar 26, 2026 at 08:17:51PM -0400, Bruce Momjian wrote:
On Thu, Mar 26, 2026 at 08:15:37PM -0400, Andres Freund wrote:
We haven't integrated changes from FreeBSD in decades, I think? I doubt it'll
ever happen again, we've patched it too much for that, I suspect.Yes, I think that is true.
Updates are unlikely, IMO, but who knows. FWIW, I don't mind fixing
these. At least somebody has spent some time sending a patch for
them.
Agreed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.