on_shmem_exit() callback function type.

Started by Kurt Roeckxabout 22 years ago2 messages
#1Kurt Roeckx
Q@ping.be

It seems that on_shmem_exit() first argument is a function that
needs to be called back. The function itself doesn't have a
prototype, but it's called with and int and Datum as argument
when it's used.

It seems that almost none of the functions it calls will actually
need any argument, I could only found 3 that actually use it.

Those most weird one was DummyProcKill, which itself doesn't take
any arguments, but it asked to be called with proctype as
argument.

Should I convert them all to take the 2 arguments instead, or
just leave it as is?

Kurt

#2Bruce Momjian
pgman@candle.pha.pa.us
In reply to: Kurt Roeckx (#1)
Re: on_shmem_exit() callback function type.

Kurt Roeckx wrote:

It seems that on_shmem_exit() first argument is a function that
needs to be called back. The function itself doesn't have a
prototype, but it's called with and int and Datum as argument
when it's used.

It seems that almost none of the functions it calls will actually
need any argument, I could only found 3 that actually use it.

Those most weird one was DummyProcKill, which itself doesn't take
any arguments, but it asked to be called with proctype as
argument.

Should I convert them all to take the 2 arguments instead, or
just leave it as is?

If you wish to clean up that area, feel free. It could use it.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073