Thread code not vpath-safe

Alvaro Herrera wrote:

The thread testing program is not nice to a vpath build. I see this
error:

checking for gmake... gmake
checking thread safety of required library functions... Makefile:13: ../../../src/Makefile.global: No such file or directory
gmake: *** No rule to make target `../../../src/Makefile.global'. Stop.
configure: error: Can not clean thread test directory.

(Basically what I'm doing is create an empty directory, cd to it and
then call ../sourcedir/configure --enable-thread-safety)

I tried and couldn't get it to fail. Do you have this line at the
bottom of configure.in:

if ! $srcdir/src/tools/thread/thread_test >&5

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

On Mon, Apr 26, 2004 at 01:15:13PM -0400, Bruce Momjian wrote:

Alvaro Herrera wrote:

The thread testing program is not nice to a vpath build. I see this
error:

(Basically what I'm doing is create an empty directory, cd to it and
then call ../sourcedir/configure --enable-thread-safety)

I tried and couldn't get it to fail.

Whoa, seems I'm the irreproducible-bug-reporter now :-(

Do you have this line at the bottom of configure.in:

if ! $srcdir/src/tools/thread/thread_test >&5

Yes:

if ! $srcdir/src/tools/thread/thread_test >&5
then rm -f $srcdir/src/Makefile.global
echo "no"
echo
$srcdir/src/tools/thread/thread_test
echo
AC_MSG_ERROR([Thread test program failed. Your platform is not thread-safe.])
fi

I tried it with:

mkdir /tmp/thr
cd /tmp/thr
~/CVS/pgsql/source/00orig/configure --enable-thread-safety

[lots of output, and then:]
checking for gmake... gmake
checking thread safety of required library functions... Makefile:13: ../../../src/Makefile.global: No such file or directory
gmake: *** No rule to make target `../../../src/Makefile.global'. Stop.
configure: error: Can not clean thread test directory.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"No necesitamos banderas
No reconocemos fronteras" (Jorge Gonz�lez)

OK, I worked with Alvaro via IM and it is fixed now.

---------------------------------------------------------------------------

Alvaro Herrera wrote:

On Mon, Apr 26, 2004 at 01:15:13PM -0400, Bruce Momjian wrote:

Alvaro Herrera wrote:

The thread testing program is not nice to a vpath build. I see this
error:

(Basically what I'm doing is create an empty directory, cd to it and
then call ../sourcedir/configure --enable-thread-safety)

I tried and couldn't get it to fail.

Whoa, seems I'm the irreproducible-bug-reporter now :-(

Do you have this line at the bottom of configure.in:

if ! $srcdir/src/tools/thread/thread_test >&5

Yes:

if ! $srcdir/src/tools/thread/thread_test >&5
then rm -f $srcdir/src/Makefile.global
echo "no"
echo
$srcdir/src/tools/thread/thread_test
echo
AC_MSG_ERROR([Thread test program failed. Your platform is not thread-safe.])
fi

I tried it with:

mkdir /tmp/thr
cd /tmp/thr
~/CVS/pgsql/source/00orig/configure --enable-thread-safety

[lots of output, and then:]
checking for gmake... gmake
checking thread safety of required library functions... Makefile:13: ../../../src/Makefile.global: No such file or directory
gmake: *** No rule to make target `../../../src/Makefile.global'. Stop.
configure: error: Can not clean thread test directory.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"No necesitamos banderas
No reconocemos fronteras" (Jorge Gonz?lez)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

On Mon, Apr 26, 2004 at 03:09:48PM -0400, Bruce Momjian wrote:

OK, I worked with Alvaro via IM and it is fixed now.

It worked cleanly for me. Thanks.

Also, the thread flags look correct, but then I'm not a "threaded
person."

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Tiene valor aquel que admite que es un cobarde" (Fernandel)