patch for different join result order on regression test for win32

Started by Andrew Dunstanover 21 years ago8 messages

Andrew Dunstan

andrew@dunslane.net

over 21 years ago

2 attachment(s)

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

cheers

andrew

Attachments:

resultmap.patchtext/plain; name=resultmap.patchDownload

Index: src/test/regress/resultmap
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/test/regress/resultmap,v
retrieving revision 1.73
diff -c -r1.73 resultmap
*** src/test/regress/resultmap	2 May 2004 04:27:37 -0000	1.73
--- src/test/regress/resultmap	10 May 2004 17:09:09 -0000
***************
*** 27,32 ****
--- 27,33 ----
  horology/.*-sco=horology-solaris-1947
  int8/.*-qnx=int8-exp-three-digits
  int8/i.86-pc-mingw32=int8-exp-three-digits-win32
+ join/i.86-pc-mingw32=join-win32
  tinterval/.*-aix4=tinterval-solaris-1947
  tinterval/.*-aix5=tinterval-solaris-1947
  tinterval/alpha.*-dec-osf=tinterval-solaris-1947

join-win32.outtext/plain; name=join-win32.outDownload

Bruce Momjian

pgman@candle.pha.pa.us

over 21 years ago

In reply to: Andrew Dunstan (#1)

Re: [PATCHES] patch for different join result order on regression test

Agreed it is time to get this regression test working on MinGW. I
suggest we add ORDER BY to the needed queries. Tom as hoping to come up
with a better solution, but at this point I think we should just add the
ORDER BY rather than adding a different output file.

Comments?

---------------------------------------------------------------------------

Andrew Dunstan wrote:

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

cheers

andrew

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Tom Lane

tgl@sss.pgh.pa.us

over 21 years ago

In reply to: Andrew Dunstan (#1)

Re: patch for different join result order on regression test for win32

Andrew Dunstan <andrew@dunslane.net> writes:

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

This is the hard way to do it. Instead of using the resultmap
mechanism, pretend the difference is a locale difference, and
just add the file as "join_1.out" (I think that's the right naming
convention, but check it). I don't think we really need to tie this
to a specific OS, which is what the resultmap mechanism is intended
to do. IIRC people have gotten similar differences on other OSes.

regards, tom lane

Tom Lane

tgl@sss.pgh.pa.us

over 21 years ago

In reply to: Bruce Momjian (#2)

Re: [PATCHES] patch for different join result order on regression test

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Agreed it is time to get this regression test working on MinGW. I
suggest we add ORDER BY to the needed queries.

Please do not do that. This is a join test, not an ORDER BY test,
and I don't want it ignoring unordered join methods.

regards, tom lane

Bruce Momjian

pgman@candle.pha.pa.us

over 21 years ago

In reply to: Tom Lane (#4)

Re: [PATCHES] patch for different join result order on regression

Tom Lane wrote:

Bruce Momjian <pgman@candle.pha.pa.us> writes:

Agreed it is time to get this regression test working on MinGW. I
suggest we add ORDER BY to the needed queries.

Please do not do that. This is a join test, not an ORDER BY test,
and I don't want it ignoring unordered join methods.

Ah, OK.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Andrew Dunstan

andrew@dunslane.net

over 21 years ago

In reply to: Tom Lane (#3)

Re: patch for different join result order on regression

Tom Lane wrote:

Andrew Dunstan <andrew@dunslane.net> writes:

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

This is the hard way to do it. Instead of using the resultmap
mechanism, pretend the difference is a locale difference, and
just add the file as "join_1.out" (I think that's the right naming
convention, but check it). I don't think we really need to tie this
to a specific OS, which is what the resultmap mechanism is intended
to do. IIRC people have gotten similar differences on other OSes.

I wondered about that.

Sounds good to me.

You are correct that ${EXPECTED}_[0-9].out is the syntax for alternative
result files. So here "join_1.out" would be fine.

cheers

andrew

Andrew Dunstan

andrew@dunslane.net

over 21 years ago

In reply to: Andrew Dunstan (#1)

Re: patch for different join result order on regression test for

Andrew Dunstan wrote:

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

Could someone please add the join result I posted in the original of
this email (on May 10th) as src/test/regress/expected/join_1.out?

This is the one test I am failing on Win32.

Fixup patch for pg_regress.sh will be sent shortly, allowing "make
check" to run cleanly.

cheers

andrew

Bruce Momjian

pgman@candle.pha.pa.us

over 21 years ago

In reply to: Andrew Dunstan (#7)

Re: patch for different join result order on regression test

Done.

---------------------------------------------------------------------------

Andrew Dunstan wrote:

Andrew Dunstan wrote:

This resultmap patch and regression test result file allow the join
regression test to succeed under Mingw.

Could someone please add the join result I posted in the original of
this email (on May 10th) as src/test/regress/expected/join_1.out?

This is the one test I am failing on Win32.

Fixup patch for pg_regress.sh will be sent shortly, allowing "make
check" to run cleanly.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073