pg_autovacuum fixes

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:

This weekend I am trying to fix up all known the pg_autovacuum issues
that should be resolved for 7.4.3. I am aware of only two issues: temp
table issues, and unchecked send_query() calls, if I am forgetting
something, please let me know.

1) temp table issue:
I was not able to reproduce the crash associated with temp tables. I
spent a while creating tables doing updates and dropping them trying
without success to get pg_autovacuum to crash. Since I couldn't trigger
the problem, I will need someone else to test to see if I have fixed the
problem. Anyway, I have modified the query to exclude temp tables from
the list of tables to work with. So we should no longer be dealing with
temp tables at all which should side step any temp table related problem
we might have been having.

2) Unchecked send_query() function calls:
As best as I can tell, this is mostly a non-issue, but I went ahead
added a check to any section that did anything with the result of
send_query, so if this was an issue, it should be fixed now. BTW, this
might have been the cause of the temp table related crash, but that is
just a guess.

Matthew O'Connor

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Matthew T. O'Connor wrote:

This weekend I am trying to fix up all known the pg_autovacuum issues
that should be resolved for 7.4.3. I am aware of only two issues: temp
table issues, and unchecked send_query() calls, if I am forgetting
something, please let me know.

1) temp table issue:
I was not able to reproduce the crash associated with temp tables. I
spent a while creating tables doing updates and dropping them trying
without success to get pg_autovacuum to crash. Since I couldn't trigger
the problem, I will need someone else to test to see if I have fixed the
problem. Anyway, I have modified the query to exclude temp tables from
the list of tables to work with. So we should no longer be dealing with
temp tables at all which should side step any temp table related problem
we might have been having.

2) Unchecked send_query() function calls:
As best as I can tell, this is mostly a non-issue, but I went ahead
added a check to any section that did anything with the result of
send_query, so if this was an issue, it should be fixed now. BTW, this
might have been the cause of the temp table related crash, but that is
just a guess.

It is not a non-issue. A query could fail for thousands of reasons, and
doing a core dump is never a solution.

Yes, these are the only two known issues.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Patch applied. Thanks.

Backpatched to 7.4.X.

---------------------------------------------------------------------------

Matthew T. O'Connor wrote:

This weekend I am trying to fix up all known the pg_autovacuum issues
that should be resolved for 7.4.3. I am aware of only two issues: temp
table issues, and unchecked send_query() calls, if I am forgetting
something, please let me know.

1) temp table issue:
I was not able to reproduce the crash associated with temp tables. I
spent a while creating tables doing updates and dropping them trying
without success to get pg_autovacuum to crash. Since I couldn't trigger
the problem, I will need someone else to test to see if I have fixed the
problem. Anyway, I have modified the query to exclude temp tables from
the list of tables to work with. So we should no longer be dealing with
temp tables at all which should side step any temp table related problem
we might have been having.

2) Unchecked send_query() function calls:
As best as I can tell, this is mostly a non-issue, but I went ahead
added a check to any section that did anything with the result of
send_query, so if this was an issue, it should be fixed now. BTW, this
might have been the cause of the temp table related crash, but that is
just a guess.

Matthew O'Connor

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faqs/FAQ.html

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073