POLL: Adding transaction status to default psql prompt

Started by Vik Fearingabout 6 years ago25 messagesgeneral
Jump to latest
#1Vik Fearing
vik@postgresfriends.org

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
-- 
Vik Fearing
#2Nikolay Samokhvalov
samokhvalov@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

+1 of course

On Wed, Feb 5, 2020 at 6:55 PM Vik Fearing <vik@postgresfriends.org> wrote:

Show quoted text

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing
#3Ahmed, Nawaz (Fuji Xerox Australia)
Nawaz.Ahmed@aus.fujixerox.com
In reply to: Vik Fearing (#1)
RE: POLL: Adding transaction status to default psql prompt

+1

-----Original Message-----
From: Vik Fearing <vik@postgresfriends.org>
Sent: Thursday, 6 February 2020 1:55 PM
To: pgsql-general@lists.postgresql.org
Subject: POLL: Adding transaction status to default psql prompt

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was requested.

Please answer +1 if you want or don't mind seeing transaction status by default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing

IMPORTANT NOTE: Fuji Xerox email transmission, including any attachments, is private and confidential and may contain legally privileged information. It is for the addressee's attention only. If you are not the intended recipient and have received this transmission, you must not use, edit, print, copy or disclose its contents to any person or disseminate the information contained herein or hereto attached, and you must notify sender immediately by return email and delete this transmission from your system. Any confidentiality, privilege or copyright is not waived or lost because this e-mail has been sent to you in error. We have used reasonable efforts to protect this transmission from computer viruses and other malicious software, but no warranty is made and the sender takes no responsibility for any loss or damage incurred from using this email or the information contained in this email.

#4Matt Zagrabelny
mzagrabe@d.umn.edu
In reply to: Ahmed, Nawaz (Fuji Xerox Australia) (#3)
Re: POLL: Adding transaction status to default psql prompt

+1

On Wed, Feb 5, 2020 at 9:15 PM Ahmed, Nawaz (Fuji Xerox Australia)
<Nawaz.Ahmed@aus.fujixerox.com> wrote:

Show quoted text

+1

-----Original Message-----
From: Vik Fearing <vik@postgresfriends.org>
Sent: Thursday, 6 February 2020 1:55 PM
To: pgsql-general@lists.postgresql.org
Subject: POLL: Adding transaction status to default psql prompt

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was requested.

Please answer +1 if you want or don't mind seeing transaction status by default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing

IMPORTANT NOTE: Fuji Xerox email transmission, including any attachments, is private and confidential and may contain legally privileged information. It is for the addressee's attention only. If you are not the intended recipient and have received this transmission, you must not use, edit, print, copy or disclose its contents to any person or disseminate the information contained herein or hereto attached, and you must notify sender immediately by return email and delete this transmission from your system. Any confidentiality, privilege or copyright is not waived or lost because this e-mail has been sent to you in error. We have used reasonable efforts to protect this transmission from computer viruses and other malicious software, but no warranty is made and the sender takes no responsibility for any loss or damage incurred from using this email or the information contained in this email.

#5Ian Lawrence Barwick
barwick@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Thu, 6 Feb 2020 at 11:55, Vik Fearing <vik@postgresfriends.org> wrote:

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1 from me.

I've been configuring this in every single .psqlrc I "own" since it was
first added in 7.4,
and sorely miss it not being just available in environments I don't "own".

Regards

Ian Barwick

#6Steve Baldwin
steve.baldwin@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

Hi Vik,

I'm not sure why this should be the default when it is easy to override the
default via a psqrc file. If you know enough to do it, you can. Otherwise I
don't think it adds any value as a default since a novice user isn't going
to know what */!/? means. Maybe I'm missing something.

-1 from me.

On Thu, Feb 6, 2020 at 1:55 PM Vik Fearing <vik@postgresfriends.org> wrote:

Show quoted text

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing
#7Vik Fearing
vik@postgresfriends.org
In reply to: Steve Baldwin (#6)
Re: POLL: Adding transaction status to default psql prompt

On 06/02/2020 04:55, Steve Baldwin wrote:

Hi Vik,

I'm not sure why this should be the default when it is easy to override the
default via a psqrc file. If you know enough to do it, you can.

Because it isn't always easy to modify the .psqlrc file. This is
especially true if you frequently connect to other people's systems.

Otherwise I
don't think it adds any value as a default since a novice user isn't going
to know what */!/? means. Maybe I'm missing something.

A novice user won't understand any of psql's meta commands, either.

-1 from me.

Thank you for voting.
--
Vik Fearing

#8Hari Kiran
hari.kiran@2ndquadrant.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On 06/02/20 8:24 am, Vik Fearing wrote:

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.

double +1 from me

#9Michael Paquier
michael@paquier.xyz
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Thanks Vik for starting a new thread. For reference here is the
thread where the patch is being discussed:
/messages/by-id/09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com
--
Michael

#10Christophe Pettus
xof@thebuild.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Feb 5, 2020, at 18:54, Vik Fearing <vik@postgresfriends.org> wrote:
Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1.

#11Adrian Klaver
adrian.klaver@aklaver.com
In reply to: Vik Fearing (#7)
Re: POLL: Adding transaction status to default psql prompt

On 2/5/20 8:05 PM, Vik Fearing wrote:

On 06/02/2020 04:55, Steve Baldwin wrote:

Hi Vik,

I'm not sure why this should be the default when it is easy to override the
default via a psqrc file. If you know enough to do it, you can.

Because it isn't always easy to modify the .psqlrc file. This is
especially true if you frequently connect to other people's systems.

Otherwise I
don't think it adds any value as a default since a novice user isn't going
to know what */!/? means. Maybe I'm missing something.

A novice user won't understand any of psql's meta commands, either.

Except they can be found by doing \?

-1

-1 from me.

Thank you for voting.

--
Adrian Klaver
adrian.klaver@aklaver.com

#12David G. Johnston
david.g.johnston@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Wed, Feb 5, 2020 at 7:55 PM Vik Fearing <vik@postgresfriends.org> wrote:

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

#13Daevor The Devoted
dollien@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

+1

(+10 billion actually, but sadly, I'm only allowed a +1)

On Thu, Feb 6, 2020 at 4:55 AM Vik Fearing <vik@postgresfriends.org> wrote:

Show quoted text

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing
#14Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Thu, 2020-02-06 at 03:54 +0100, Vik Fearing wrote:

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

+1

Yours,
Laurenz Albe

#15Guillaume Lelarge
guillaume@lelarge.info
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

Le jeu. 6 févr. 2020 à 03:55, Vik Fearing <vik@postgresfriends.org> a
écrit :

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,

Too bad it doesn't add a space, so that we still have the same space used
byt the prompt whatever the status of the transaction. That's probably the
only thing that bugs me with %x.

- adding a '*' when in a transaction or a '!' when in an aborted

transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.

+1 from me as well. Actually, thanks to you, I added it to my .psqlrc file
in the meantime. But it would be very interesting when I work on a
customer's server.

--
Guillaume.

In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

depesz

#17Daniel Westermann (DWE)
daniel.westermann@dbi-services.com
In reply to: hubert depesz lubaczewski (#16)
Re: POLL: Adding transaction status to default psql prompt

On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

+1

Daniel

#18Ray O'Donnell
ray@rodonnell.ie
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

On 06/02/2020 02:54, Vik Fearing wrote:

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

--
Raymond O'Donnell // Galway // Ireland
ray@rodonnell.ie

#19Victor Yegorov
vyegorov@gmail.com
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

чт, 6 февр. 2020 г. в 04:55, Vik Fearing <vik@postgresfriends.org>:

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

--
Victor Yegorov

#20Charles Clavadetscher
clavadetscher@swisspug.org
In reply to: Vik Fearing (#1)
Re: POLL: Adding transaction status to default psql prompt

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1

--
Charles Clavadetscher
Swiss PostgreSQL Users Group
Treasurer
Spitzackerstrasse 9
CH - 8057 Zürich

http://www.swisspug.org

+---------------------------+
| ____ ______ ___ |
| / )/ \/ \ |
| ( / __ _\ ) |
| \ (/ o) ( o) ) |
| \_ (_ ) \ ) _/ |
| \ /\_/ \)/ |
| \/ <//| |\\> |
| _| | |
| \|_/ |
| |
| Swiss PGDay 2020 |
| 18/19.06.2020 |
| HSR Rapperswil |
| |
+---------------------------+

#21Fabrízio de Royes Mello
fabriziomello@gmail.com
In reply to: Vik Fearing (#1)
#22Nikolay Samokhvalov
samokhvalov@gmail.com
In reply to: Vik Fearing (#7)
#23Ken Tanzer
ken.tanzer@gmail.com
In reply to: Fabrízio de Royes Mello (#21)
#24Kasun Kulathunga
kask18@gmail.com
In reply to: Ken Tanzer (#23)
#25Anthony Nowocien
anowocien@gmail.com
In reply to: Kasun Kulathunga (#24)