Problem building psql on Mac OS 10.15 (around readline bit I think)

Ben Madin <ben@ausvet.com.au> writes:

I am trying to build PostgreSQL 13.2 on Mac OS X 10.15.7. I was about to
build 13.1 on the same 10.15 (but probably not 10.15.7) about 8 weeks ago
without problems, so I was a bit surprised to find this error happening.

*input.c:82:3: error: implicit declaration of function
'rl_reset_screen_size' is invalid in C99*
[-Werror,-Wimplicit-function-declaration]
rl_reset_screen_size();
^
input.c:82:3: note: did you mean 'rl_set_screen_size'?
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/readline/history.h:198:8:
note:
'rl_set_screen_size' declared here
void rl_set_screen_size(int, int);
^

That's odd. Did you update Xcode or Apple's "command line tools" since
your last successful PG build? Do you have either MacPorts or Homebrew
stuff on this machine?

FWIW, I don't think we've changed anything in this immediate area in
quite some time. So I guess something in your environment changed,
but it's not clear what.

regards, tom lane

Hi Tom,

thanks for such a quick reply - there's the rub, I really can't think of
anything other than apple point updates.

I checked the configure output, and it noted that neither of those
functions were available (but didn't appear to change anything or not try
building)

I then installed readline-8.1, and added:

./configure --prefix=/usr/local/pgsql-${PG_VERSION}
--with-extra-version=-bm \
--with-bonjour --with-uuid=e2fs \
--with-libxml --with-libxslt \
--with-python
PYTHON=/Library/Frameworks/Python.framework/Versions/3.9/bin/python3 \
--with-system-tzdata=/usr/share/zoneinfo \
--with-openssl \
--with-libraries=/usr/local/ssl/lib:/usr/local/lib \
--with-includes=/usr/local/ssl/include:/usr/local/include/readline

to the configure, and the configure output now showed both available,

checking for rl_reset_screen_size... yes
checking for append_history... yes

and it shows

configure: using CPPFLAGS=-isysroot $(PG_SYSROOT)
-I/usr/local/include/libxml2 -I/usr/local/ssl/include
-I/usr/local/include/readline
configure: using LDFLAGS=-isysroot $(PG_SYSROOT) -L/usr/local/lib
-L/usr/local/ssl/lib -Wl,-dead_strip_dylibs

at the bottom of the configure output but the build script still failed at
the same point showing the same error citing the readline/history.h from
the apple SDK's... is there something else I have to do to ensure it uses
the ones on the PATH and specified in the configure?

cheers

Ben

On Mon, 1 Mar 2021 at 12:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Ben Madin <ben@ausvet.com.au> writes:

I am trying to build PostgreSQL 13.2 on Mac OS X 10.15.7. I was about to
build 13.1 on the same 10.15 (but probably not 10.15.7) about 8 weeks ago
without problems, so I was a bit surprised to find this error happening.

*input.c:82:3: error: implicit declaration of function
'rl_reset_screen_size' is invalid in C99*
[-Werror,-Wimplicit-function-declaration]
rl_reset_screen_size();
^
input.c:82:3: note: did you mean 'rl_set_screen_size'?

/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/readline/history.h:198:8:

note:
'rl_set_screen_size' declared here
void rl_set_screen_size(int, int);
^

That's odd. Did you update Xcode or Apple's "command line tools" since
your last successful PG build? Do you have either MacPorts or Homebrew
stuff on this machine?

FWIW, I don't think we've changed anything in this immediate area in
quite some time. So I guess something in your environment changed,
but it's not clear what.

regards, tom lane

--

[image: Ausvet Logo] <https://www.ausvet.com.au/&gt;

Dr Ben Madin

BVMS MVPHMgmt PhD MANZCVS GAICD
Managing Director
Mobile:
+61 448 887 220 <+61448887220>
E-mail:
ben@ausvet.com.au
Website:
www.ausvet.com.au
Skype: benmadin
Address:
5 Shuffrey Street
Fremantle, WA 6160
Australia