Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?

Started by zxwsbgover 3 years ago2 messagesgeneral
Jump to latest
#1zxwsbg
zxwsbg@qq.com

Last email has some problem, I resend one.

In PG14 or higher version, I notice that SnapBuildRestore function don't set builder->next_phase_at=InvalidTransactionId .

But in SnapBuildSerialize function, the assert check this condition.

Assert(builder->next_phase_at == InvalidTransactionId);

I'd like to know is this right?

Thanks.

#2zxwsbg
zxwsbg@qq.com
In reply to: zxwsbg (#1)
Re:Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?

I don't know what happened, but an image seems to be better.
------------------ Original ------------------
From: "zxwsbg" <zxwsbg@qq.com&gt;;
Date:&nbsp;Thu, Nov 24, 2022 04:01 PM
To:&nbsp;"pgsql-general"<pgsql-general@postgresql.org&gt;;

Subject:&nbsp;Why not set builder-&gt;next_phase_at=InvalidTransactionId in SnapBuildRestore function?

Last email has some problem, I resend one.

In PG14 or higher version, I notice that SnapBuildRestore function don't set builder-&gt;next_phase_at=InvalidTransactionId .

But in SnapBuildSerialize function, the assert check this condition.

Assert(builder-&gt;next_phase_at == InvalidTransactionId);

I'd like to know is this right?

Thanks.

Attachments:

8E5E5C66@0E44FF52.59257F63.png.jpgimage/jpeg; name="8E5E5C66@0E44FF52.59257F63.png.jpg"Download