[PATCH] analyze: move elevel calculation into do_analyze_rel()
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t139178_3 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t139178_3 && git checkout t139178_3Patchset v3 (message #3) is on t139178_3
Attachments:
0001-analyze-move-elevel-calculation-into-do_analyze_rel.patchtext/x-diff; name=0001-analyze-move-elevel-calculation-into-do_analyze_rel.patchDownload+12-13
Hi hackers,
I reworked the patch slightly.
Since do_analyze_rel() is static, removing the extra elevel argument is
local to analyze.c only. No behavioral change is intended.
--
Best regards,
Lev Nikolaev,
Tantor Labs LLC,
30.03.2026 16:03, Лев Николаев пишет:
Show quoted text
Hi hackers,
While reading analyze.c in current master, I noticed a small cleanup
opportunity in the ANALYZE code path.Currently, analyze_rel() computes elevel from params.options, but does
not use it directly. It only passes the value down to
do_analyze_rel(). At the same time, do_analyze_rel() already receives
params and derives verbose from params.options for its own purposes.The attached patch moves the elevel calculation into do_analyze_rel()
and removes the extra elevel argument from its declaration,
definition, and call sites.No behavioral change is intended here. The logging level selection
remains the same; the calculation is just moved closer to the actual
use sites.Comments and feedback would be appreciated.
--
Best regards,
Lev Nikolaev,
Tantor Labs LLC,
Attachments:
0001-analyze-move-elevel-calculation-into-do_analyze_rel.patchtext/x-patch; charset=UTF-8; name=0001-analyze-move-elevel-calculation-into-do_analyze_rel.patchDownload+13-14
On 3/31/26 7:56 PM, Lev Nikolaev wrote:
I reworked the patch slightly.
This small cleanup makes sense to me since do_analyze_rel() already
looks at if VACOPT_VERBOSE is set meaning related code is grouped closer
after this small refactoring.
The patch no longer applied so I rebased it.
Andreas
On Thu, Apr 2, 2026 at 8:29 AM Andreas Karlsson <andreas@proxel.se> wrote:
On 3/31/26 7:56 PM, Lev Nikolaev wrote:
I reworked the patch slightly.
This small cleanup makes sense to me since do_analyze_rel() already
looks at if VACOPT_VERBOSE is set meaning related code is grouped closer
after this small refactoring.The patch no longer applied so I rebased it.
Sorry, but -1 from me because this change would lead to doing the same
setup repeatedly when analyzing inheritance trees, which is not great.
Best regards,
Etsuro Fujita