Remove commented-out code in 026_overwrite_contrecord.pl
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t139209psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 02:20 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t139209_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t139209_1 && git checkout t139209_1Patchset v1 (message #1) is on t139209_1
Hi
There is some unused commented line of code in the tap test file `
026_overwrite_contrecord.pl` [1]https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61. Looks like a left over from earlier test
development.
Remove it for clarity.
Thanks,
Imran Zaheer
[1]: https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61
https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61
On Fri, 3 Apr 2026 at 19:26, Imran Zaheer <imran.zhir@gmail.com> wrote:
Hi
There is some unused commented line of code in the tap test file `026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test development.
I agree with you, +1 to remove this.
Regards,
Vignesh
