Remove commented-out code in 026_overwrite_contrecord.pl

Started by Imran Zaheer11 days ago3 messageshackers

imran.zhir@gmail.com

11 days ago

There is some unused commented line of code in the tap test file `
026_overwrite_contrecord.pl` [1]https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61. Looks like a left over from earlier test
development.

Remove it for clarity.

Thanks,
Imran Zaheer

[1]: https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61
https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery/t/026_overwrite_contrecord.pl#L61

vignesh C

vignesh21@gmail.com

8 days ago

In reply to: Imran Zaheer (#1)

Re: Remove commented-out code in 026_overwrite_contrecord.pl

On Fri, 3 Apr 2026 at 19:26, Imran Zaheer <imran.zhir@gmail.com> wrote:

Hi

There is some unused commented line of code in the tap test file `026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test development.

I agree with you, +1 to remove this.

Regards,
Vignesh

Michael Paquier

michael@paquier.xyz

7 days ago

In reply to: vignesh C (#2)

Re: Remove commented-out code in 026_overwrite_contrecord.pl

On Mon, Apr 06, 2026 at 03:10:50PM +0530, vignesh C wrote:

I agree with you, +1 to remove this.

Thanks. This is cosmetic, so I have grabbed that for later, saved it
on a staging branch with a bunch of other things.
--
Michael

Remove commented-out code in 026_overwrite_contrecord.pl

Attachments: