Upload only the failed tests logs to the Postgres CI (Cirrus CI)

Hi,

On Tue, 7 Apr 2026 at 19:18, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

Note: Currently NetBSD is failing with: 'env: python3: No such file or
directory', this can be fixed separately but I wanted to hear your
thoughts first.

Quick update: Windows CI tasks seem to be running into issues. Like
NetBSD, they can be fixed separately.

--
Regards,
Nazir Bilal Yavuz
Microsoft

Hi,

On Tue, 7 Apr 2026 at 19:27, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

Hi,

On Tue, 7 Apr 2026 at 19:18, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

Note: Currently NetBSD is failing with: 'env: python3: No such file or
directory', this can be fixed separately but I wanted to hear your
thoughts first.

Quick update: Windows CI tasks seem to be running into issues. Like
NetBSD, they can be fixed separately.

Here is v2, which addresses the issues I mentioned earlier.

I have updated the design since this will only be used for Meson
builds. I decided to invoke the script using 'meson compile
clear_testrun_folder', as this avoids the need to manually call
python3. This approach prevents issues on NetBSD, where the python3
environment may not be found.

I don’t expect the 'ci_meson_clear_testrun_folder' script to be used
outside of CI, so I placed it in the 'src/tools/ci/' directory.
However, if you think it could be useful beyond CI, we could consider
renaming it and moving it to 'src/tools/'.

--
Regards,
Nazir Bilal Yavuz
Microsoft

Hi,

On Thu, 9 Apr 2026 at 11:01, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

On Tue, 7 Apr 2026 at 19:27, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:

Here is v2, which addresses the issues I mentioned earlier.

I have updated the design since this will only be used for Meson
builds. I decided to invoke the script using 'meson compile
clear_testrun_folder', as this avoids the need to manually call
python3. This approach prevents issues on NetBSD, where the python3
environment may not be found.

I don’t expect the 'ci_meson_clear_testrun_folder' script to be used
outside of CI, so I placed it in the 'src/tools/ci/' directory.
However, if you think it could be useful beyond CI, we could consider
renaming it and moving it to 'src/tools/'.

Here is the v3, it is modified for Github Actions.

I implemented it as another step which will run if the job fails.
Alternatively, we can put 'the clearing command' into the
meson_test_world step, this makes the change simpler but then this
command will run although tests don't fail.

With this change, the compressed size of the log decreases from ~8MB
to ~1MB. Also, it is much easier to find which tests failed.

You can see example GHA run, which intentionally failed:
https://github.com/nbyavuz/postgres/actions/runs/27013199064

--
Regards,
Nazir Bilal Yavuz
Microsoft

Hi,

On 2026-06-05 15:23:52 +0300, Nazir Bilal Yavuz wrote:

I implemented it as another step which will run if the job fails.
Alternatively, we can put 'the clearing command' into the
meson_test_world step, this makes the change simpler but then this
command will run although tests don't fail.

I think it's the right thing to have it as a dedicated step. That way it can
work with things like the running tests etc as well.

+ # Clear test folder so only failed tests are left

FWIW, I'd much rather see this copy the to-be-archived logs to a different
location, instead of removing the unneeded logs.

+      - &clear_test_folder_step
+        name: Clear test folder
+        if: failure() && !cancelled()
+        run: |
+          meson compile clear_testrun_folder -C build

I don't think I see what we gain from invoking this via meson compile, given
that we invoke ninja directly elsewhere. Not that that's going to make the
difference, but meson compile, which internally invokes ninja, is noticeably
slower than going through ninja directly.

But I suspect this shouldn't be integrated into the build system directly, as
I think we should eventually make this work for autoconf as well.

Greetings,

Andres Freund

Hi,

Thank you for looking into this!

On Mon, 8 Jun 2026 at 18:10, Andres Freund <andres@anarazel.de> wrote:

On 2026-06-05 15:23:52 +0300, Nazir Bilal Yavuz wrote:

I implemented it as another step which will run if the job fails.
Alternatively, we can put 'the clearing command' into the
meson_test_world step, this makes the change simpler but then this
command will run although tests don't fail.

I think it's the right thing to have it as a dedicated step. That way it can
work with things like the running tests etc as well.

+ # Clear test folder so only failed tests are left

FWIW, I'd much rather see this copy the to-be-archived logs to a different
location, instead of removing the unneeded logs.

Should we upload these logs too? If so, perhaps we can have something like:

build/testrun/successful_tests/*
build/testrun/failed_tests/*

Do you think this makes sense?

+      - &clear_test_folder_step
+        name: Clear test folder
+        if: failure() && !cancelled()
+        run: |
+          meson compile clear_testrun_folder -C build

I don't think I see what we gain from invoking this via meson compile, given
that we invoke ninja directly elsewhere. Not that that's going to make the
difference, but meson compile, which internally invokes ninja, is noticeably
slower than going through ninja directly.

I got it, I will change this.

But I suspect this shouldn't be integrated into the build system directly, as
I think we should eventually make this work for autoconf as well.

There were couple of reasons:

1- That was easy to implement for meson build because we have a
'test.success' file for the successful tests, AFAIK we don't have a
similar thing for the autoconf.

2- python3 was not available on the PATH for some OSes, so I
indirectly used python3 from the meson.

--
Regards,
Nazir Bilal Yavuz
Microsoft