pg_stash_advice doc

Started by Erik Rijkers4 months ago3 messageshackers
Jump to latest
#1Erik Rijkers
er@xs4all.nl

Hi,

The pg_stash_advice doc ( doc/src/sgml/pgstashadvice.sgml ) contains
this sentence:

"This means both that it is important to be mindful
of memory consumption when deciding how much plan advice to stash."

It seems to me 'both' should be 'also', or maybe just dropped.

Thanks,

Erik

#2Robert Haas
robertmhaas@gmail.com
In reply to: Erik Rijkers (#1)
Re: pg_stash_advice doc

On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <er@xs4all.nl> wrote:

"This means both that it is important to be mindful
of memory consumption when deciding how much plan advice to stash."

It seems to me 'both' should be 'also', or maybe just dropped.

Oops. That sentence had a second part in the first pg_stash_advice
commit, and the second commit remove the second part of the sentence
without remembering to delete the word "both".

--
Robert Haas
EDB: http://www.enterprisedb.com

#3Robert Haas
robertmhaas@gmail.com
In reply to: Robert Haas (#2)
Re: pg_stash_advice doc

On Fri, Apr 10, 2026 at 11:57 AM Robert Haas <robertmhaas@gmail.com> wrote:

On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <er@xs4all.nl> wrote:

"This means both that it is important to be mindful
of memory consumption when deciding how much plan advice to stash."

It seems to me 'both' should be 'also', or maybe just dropped.

Oops. That sentence had a second part in the first pg_stash_advice
commit, and the second commit remove the second part of the sentence
without remembering to delete the word "both".

I have committed a fix. Thanks again for the report.

--
Robert Haas
EDB: http://www.enterprisedb.com