small cleanup patches for collation code

Started by Jeff Davis13 days ago2 messageshackers
Jump to latest
#1Jeff Davis
pgsql@j-davis.com

Two patches attached.

0001 fixes a style issue. Backport because it eliminates a warning in
the 'update-unicode' target.

0002 looks like a bug, but is not a real issue because there are no
callers that pass srclen==-1, aside from a test (which fails to fail).
So it's just cleanup, but it seems worth backporting.

Regards,
Jeff Davis

Attachments:

v1-0001-style-define-parameterless-functions-as-foo-void.patchtext/x-patch; charset=UTF-8; name=v1-0001-style-define-parameterless-functions-as-foo-void.patchDownload+2-3
v1-0002-Fix-callers-of-unicode_strtitle-using-srclen-1.patchtext/x-patch; charset=UTF-8; name=v1-0002-Fix-callers-of-unicode_strtitle-using-srclen-1.patchDownload+2-3
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Jeff Davis (#1)
Re: small cleanup patches for collation code

On 17.04.26 21:30, Jeff Davis wrote:

Two patches attached.

0001 fixes a style issue. Backport because it eliminates a warning in
the 'update-unicode' target.

These warning options were only added in PG19, so backpatching is not
necessary.

0002 looks like a bug, but is not a real issue because there are no
callers that pass srclen==-1, aside from a test (which fails to fail).
So it's just cleanup, but it seems worth backporting.

That looks right.