Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

Started by SATYANARAYANA NARLAPURAM7 days ago3 messageshackers
Jump to latest
#1SATYANARAYANA NARLAPURAM
satyanarlapuram@gmail.com

Hi Hackers,

A concurrent tablespace drop could lead to null deref in
pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
fix this to keep the code clean.

Thanks,
Satya

Attachments:

0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patchapplication/octet-stream; name=0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patchDownload+2-1
#2Chao Li
li.evan.chao@gmail.com
In reply to: SATYANARAYANA NARLAPURAM (#1)
Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> wrote:

Hi Hackers,

A concurrent tablespace drop could lead to null deref in pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to fix this to keep the code clean.

Thanks,
Satya
<0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch>

This is a dup of my recent patch, see [1]/messages/by-id/573E45C1-31A4-4885-A00C-1A2171159A2A@gmail.com.

[1]: /messages/by-id/573E45C1-31A4-4885-A00C-1A2171159A2A@gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

#3SATYANARAYANA NARLAPURAM
satyanarlapuram@gmail.com
In reply to: Chao Li (#2)
Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal

Hi Chao,

On Wed, Apr 22, 2026 at 5:03 PM Chao Li <li.evan.chao@gmail.com> wrote:

On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM <

satyanarlapuram@gmail.com> wrote:

Hi Hackers,

A concurrent tablespace drop could lead to null deref in

pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch to
fix this to keep the code clean.

Thanks,
Satya

<0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.patch>

This is a dup of my recent patch, see [1].

[1]
/messages/by-id/573E45C1-31A4-4885-A00C-1A2171159A2A@gmail.com

Thanks, I replied there.