[PATCH] psql: Add missing IO option to EXPLAIN tab completion

Started by Afrah Razzak12 days ago3 messageshackers
Jump to latest
#1Afrah Razzak
mypg.afrah@gmail.com

Hi,

Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
psql's tab completion was not updated to include it.

Currently:

EXPLAIN (<Tab> -- IO is not listed
EXPLAIN (IO <Tab> -- no ON/OFF offered

The attached patch adds IO to both the option keyword list and the
boolean ON/OFF completion pattern in tab-complete.in.c.

Thanks,
Afrah Razzak

Attachments:

0001-psql-Add-missing-IO-option-to-EXPLAIN-tab-completion.patchapplication/octet-stream; name=0001-psql-Add-missing-IO-option-to-EXPLAIN-tab-completion.patchDownload+2-3
#2Zhenwei Shang
a934172442@gmail.com
In reply to: Afrah Razzak (#1)
Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion

Afrah Razzak <mypg.afrah@gmail.com> 于2026年5月13日周三 11:35写道:

Hi,

Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
psql's tab completion was not updated to include it.

Currently:

EXPLAIN (<Tab> -- IO is not listed
EXPLAIN (IO <Tab> -- no ON/OFF offered

The attached patch adds IO to both the option keyword list and the
boolean ON/OFF completion pattern in tab-complete.in.c.

Thanks,
Afrah Razzak

Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to

both the option keyword list and the ON/OFF completion branch is the right
fix.

Regards,
Zhenwei Shang

#3Fujii Masao
masao.fujii@gmail.com
In reply to: Zhenwei Shang (#2)
Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion

On Wed, May 13, 2026 at 2:49 PM Zhenwei Shang <a934172442@gmail.com> wrote:

Afrah Razzak <mypg.afrah@gmail.com> 于2026年5月13日周三 11:35写道:

Hi,

Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
psql's tab completion was not updated to include it.

Currently:

EXPLAIN (<Tab> -- IO is not listed
EXPLAIN (IO <Tab> -- no ON/OFF offered

The attached patch adds IO to both the option keyword list and the
boolean ON/OFF completion pattern in tab-complete.in.c.

Thanks,
Afrah Razzak

Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to both the option keyword list and the ON/OFF completion branch is the right fix.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao