A trivial fix on a comment in pgstat_assoc_relation()
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t139650psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 28, 2026 at 10:26 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t139650_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t139650_1 && git checkout t139650_1Patchset v1 (message #1) is on t139650_1
Hi,
I noticed that a comment in pgstat_assoc_relation() starts with "Else":
/* Else find or make the PgStat_TableStatus entry, and update link */
This seems to be a vestige from when this function was split out from pgstat_init_relation()
by commit 5891c7a8ed8f, so I think we could simply remove the "Else".
Regards,
Yugo Nagata
--
Yugo Nagata <nagata@sraoss.co.jp>
On Fri, May 15, 2026 at 03:09:41PM +0900, Yugo Nagata wrote:
This seems to be a vestige from when this function was split out from pgstat_init_relation()
by commit 5891c7a8ed8f, so I think we could simply remove the "Else".
(Received a poke from Sawada-san on this one.)
Thanks, grabbed this change for later.
--
Michael