Simplify signature of ProcessStartupPacket()

Started by Michael Paquier10 days ago5 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

In one of the recent patches committed into the tree (b63f25bddfeb),
Daniel has come up with the suggestion to simplify
ProcessStartupPacket() by removing its arguments "ssl_done" and
"gss_done", as there is now only one callers of this routine.

Please find attached a patch to do this cleanup. This is only for
HEAD, material for v20.

Thanks,
--
Michael

Attachments:

0001-Simplify-signature-of-ProcessStartupPacket.patchtext/plain; charset=us-asciiDownload+16-10
#2Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#1)
Re: Simplify signature of ProcessStartupPacket()

On 15/05/2026 09:22, Michael Paquier wrote:

Hi all,

In one of the recent patches committed into the tree (b63f25bddfeb),
Daniel has come up with the suggestion to simplify
ProcessStartupPacket() by removing its arguments "ssl_done" and
"gss_done", as there is now only one callers of this routine.

Please find attached a patch to do this cleanup. This is only for
HEAD, material for v20.

+1. And I wouldn't mind committing that for v19 already.

- Heikki

#3Michael Paquier
michael@paquier.xyz
In reply to: Heikki Linnakangas (#2)
Re: Simplify signature of ProcessStartupPacket()

On Fri, May 15, 2026 at 11:16:38AM +0300, Heikki Linnakangas wrote:

+1. And I wouldn't mind committing that for v19 already.

Thanks. FWIW, I'm cool with v19 as well.
--
Michael

#4Daniel Gustafsson
daniel@yesql.se
In reply to: Heikki Linnakangas (#2)
Re: Simplify signature of ProcessStartupPacket()

On 15 May 2026, at 10:16, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

On 15/05/2026 09:22, Michael Paquier wrote:

Hi all,
In one of the recent patches committed into the tree (b63f25bddfeb),
Daniel has come up with the suggestion to simplify
ProcessStartupPacket() by removing its arguments "ssl_done" and
"gss_done", as there is now only one callers of this routine.
Please find attached a patch to do this cleanup. This is only for
HEAD, material for v20.

+1. And I wouldn't mind committing that for v19 already.

+1, LGTM.

--
Daniel Gustafsson

#5Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#4)
Re: Simplify signature of ProcessStartupPacket()

On Sat, May 16, 2026 at 04:36:33PM +0200, Daniel Gustafsson wrote:

On 15 May 2026, at 10:16, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

+1. And I wouldn't mind committing that for v19 already.

+1, LGTM.

Thanks. Applied now on HEAD.
--
Michael